Skip to content

Conversation

@JohT
Copy link
Owner

@JohT JohT commented Oct 14, 2023

🚀 Features

⚙️ Optimization

  • Introduce functions to check and wait for Neo4j: There is now one common shell script file that provides functions to check and wait for Neo4j. Polling for a running status using the neo4j status CLI command was removed in favor of simply waiting for the HTTP port to be available, which is the most reliable way to check if Neo4j is actually running. Besides that, neo4j status doesn't work on Windows when Neo4j is started in a console instead of as a service.
  • Add info about conda environment in pipeline: An additional pipeline step prints out details about the Conda environment that is used for the Jupyter Notebooks.
  • Move conda environment activation to own script: The automated execution and conversion of Jupyter Notebooks is now separated from the creation and activation of the Conda environment. This leads now to two scripts with a clear separation of concern and reason to change. It makes them also easier to read because they are smaller and simpler.

📦 Updates

  • Migrate to jq v1.7: The update of jq from version 1.6 to 1.7 comes with a stricter validation for nested objects in columns: These need to be flattened or converted to strings before they can be converted to CSV. That's why mapView is no longer contained in the result of graph algorithm estimations. The same information is anyway contained in treeView. Additionally, lists of lists need to be flattened ideally within the Cypher query before they can be converted to CSV.

🛠 Fixes

@JohT JohT self-assigned this Oct 14, 2023
@JohT JohT force-pushed the feature/windows-support branch 3 times, most recently from b4d77a4 to d34ad3e Compare October 15, 2023 15:55
@JohT JohT force-pushed the feature/windows-support branch 7 times, most recently from ce9cd39 to 581b3d3 Compare October 30, 2023 09:52
@JohT JohT marked this pull request as ready for review October 30, 2023 10:20
@JohT JohT force-pushed the feature/windows-support branch 4 times, most recently from 1b6be1e to 3f1af98 Compare October 31, 2023 19:33
JohT added 8 commits November 1, 2023 08:30
- Fix jq error "is no valid in a csv row"
- Skip algorithm estimation result column "mapView" to overcome jq error
- Fix jq error "string and array cannot be added"
- jq flatten doesn't work on lists in lists on Windows/git bash jq-7
- Cypher plugin apoc provides a flatten function for that
@JohT JohT force-pushed the feature/windows-support branch from 9d3ea34 to 831fb8d Compare November 1, 2023 07:32
@JohT JohT merged commit 8e104af into main Nov 1, 2023
@JohT JohT deleted the feature/windows-support branch November 1, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants