Skip to content

Conversation

@JohT
Copy link
Owner

@JohT JohT commented Nov 16, 2024

⚙️ Optimization

🛠 Fix

  • Fix init script by providing forwarding scripts. Scripts that call the original one are now used Instead of symbolic links, that were not working because of their apparent working directory.
  • Exclude reports from change detection. Scan results from the jqassistant-typescript-plugin are now excluded from the change detection. Previously, the Typescript scan was repeated just because the scan reports changed. This could be considered ok, since it is also possible that the scan itself changed and then it would also make sense to trigger a rescan. However, this is an edge case for repeated local analysis and negligible.

@JohT JohT self-assigned this Nov 16, 2024
@JohT JohT changed the title Feature/improvements-for-large-scala-typescript-analysis Improvements for large scala Typescript analysis Nov 16, 2024
@JohT JohT force-pushed the feature/improvements-for-large-scala-typescript-analysis branch from d9164b2 to 690077a Compare November 17, 2024 08:31
@JohT JohT marked this pull request as ready for review November 17, 2024 09:15
@JohT JohT merged commit 77b2d1b into main Nov 17, 2024
6 checks passed
@JohT JohT deleted the feature/improvements-for-large-scala-typescript-analysis branch November 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants