Skip to content

Commit cba4b2a

Browse files
committed
Remove dependency between Jupyter and CSV reports
1 parent 6efe2b0 commit cba4b2a

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

jupyter/ExternalDependencies.ipynb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1367,11 +1367,11 @@
13671367
"plot.figure();\n",
13681368
"axes = external_package_usage_aggregated.plot(\n",
13691369
" kind='scatter',\n",
1370-
" title='External package usage - max internal packages', \n",
1370+
" title='External package usage - max internal packages %', \n",
13711371
" x='numberOfExternalPackages',\n",
13721372
" y='maxNumberOfPackagesPercentage',\n",
13731373
" s='artifactPackages',\n",
1374-
" c='leidenCommunityId',\n",
1374+
" c='stdNumberOfPackagesPercentage',\n",
13751375
" xlabel='external package count',\n",
13761376
" ylabel='max percentage of internal packages',\n",
13771377
" cmap=main_color_map,\n",
@@ -1416,11 +1416,11 @@
14161416
"plot.figure();\n",
14171417
"axes = external_package_usage_aggregated.plot(\n",
14181418
" kind='scatter',\n",
1419-
" title='External package usage - median internal packages', \n",
1419+
" title='External package usage - median internal packages %', \n",
14201420
" x='numberOfExternalPackages',\n",
14211421
" y='medNumberOfPackagesPercentage',\n",
14221422
" s='artifactPackages',\n",
1423-
" c='leidenCommunityId',\n",
1423+
" c='stdNumberOfPackagesPercentage',\n",
14241424
" xlabel='external package count',\n",
14251425
" ylabel='median percentage of internal packages',\n",
14261426
" cmap=main_color_map,\n",

scripts/reports/ArtifactDependenciesJupyter.sh

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Creates the "artifact-dependencies" report (ipynb, md, pdf) based on the Jupyter Notebook "ArtifactDependencies.ipynb".
44
# It contains the hierarchical artifact dependencies graph
55

6-
# Requires executeJupyterNotebook.sh, AritfactCommunityCsv.sh
6+
# Requires executeJupyterNotebook.sh
77

88
# Overrideable Constants (defaults also defined in sub scripts)
99
REPORTS_DIRECTORY=${REPORTS_DIRECTORY:-"reports"}
@@ -27,19 +27,10 @@ echo "ArtifactDependenciesJupyter: JUPYTER_NOTEBOOK_DIRECTORY=$JUPYTER_NOTEBOOK_
2727
CYPHER_DIR=${CYPHER_DIR:-"${REPORTS_SCRIPT_DIR}/../../cypher"}
2828
echo "ArtifactDependenciesJupyter CYPHER_DIR=${CYPHER_DIR}"
2929

30-
# Define functions to execute cypher queries from within a given file
31-
source "${SCRIPTS_DIR}/executeQueryFunctions.sh"
32-
33-
# Local Constants
34-
LEIDEN_CYPHER_DIR="$CYPHER_DIR/Community_Detection_Leiden_for_Artifacts"
35-
3630
# Create report directory
3731
REPORT_NAME="artifact-dependencies"
3832
FULL_REPORT_DIRECTORY="${REPORTS_DIRECTORY}/${REPORT_NAME}"
3933
mkdir -p "${FULL_REPORT_DIRECTORY}"
4034

41-
# Dependency: Assure that artifacts have a Leiden Community Id (written by "AritfactCommunityCsv.sh")
42-
execute_cypher_expect_results "${LEIDEN_CYPHER_DIR}/Community_Detection_8_Check_Leiden_Community_Id.cypher"
43-
4435
# Execute and convert the Jupyter Notebook "ArtifactDependencies.ipynb" within the given reports directory
4536
(cd "${FULL_REPORT_DIRECTORY}" && exec ${SCRIPTS_DIR}/executeJupyterNotebook.sh ${JUPYTER_NOTEBOOK_DIRECTORY}/ArtifactDependencies.ipynb) || exit 1

0 commit comments

Comments
 (0)