Skip to content

Commit 9abd1ea

Browse files
committed
Pass error to node to exit the script (fail fast)
1 parent 339e65b commit 9abd1ea

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

graph-visualization/renderVisualizations.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,4 @@ let browser;
128128
await takeCanvasScreenshots(browser, htmlFile);
129129
}
130130
console.log(`renderVisualizations.js: Successfully rendered ${htmlFiles.length} html file(s)`);
131-
})()
132-
.catch((err) => console.error(err))
133-
.finally(() => browser?.close());
131+
})().finally(() => browser?.close());

scripts/reports/GraphVisualization.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,6 @@ if [ ! -d "${GRAPH_VISUALIZATION_DIRECTORY}/node_modules" ] ; then
3333
fi
3434

3535
# Execute the node.js script to render the graph visualizations as image files
36-
(cd "${REPORTS_DIRECTORY}" && exec node "${GRAPH_VISUALIZATION_DIRECTORY}/renderVisualizations.js")
36+
(cd "${REPORTS_DIRECTORY}" && exec node "${GRAPH_VISUALIZATION_DIRECTORY}/renderVisualizations.js")
37+
38+
echo "GraphVisualization: Successfully finished"

0 commit comments

Comments
 (0)