Skip to content

Commit 7eadb50

Browse files
committed
Fix minor text and comment issues
1 parent 006591f commit 7eadb50

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

jupyter/ExternalDependencies.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
"\n",
119119
"### External Package\n",
120120
"\n",
121-
"A package is categorized as \"external\" if it is utilized as a dependency, or if any of its enclosed types are used as dependencies, but the code within it has not been analyzed (missing bytecode). This also applies to all build-in Java types, but they are explicitly filtered out here.\n",
121+
"An external type has no `byteCodeVersion` since it only occurs as a dependency but wasn't analyzed itself (missing bytecode). Core Java types like `java.lang.Integer` and primitives like `int` are considered \"build-in\" and therefore aren't interpreted as \"external\" even though their byte code is also missing. A package is categorized as \"external\" if the types it contains are classified as external.\n",
122122
"\n",
123123
"### External annotation dependency\n",
124124
"\n",

jupyter/InternalDependencies.ipynb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
"These dependencies can lead to a lot of trouble when one of these packages needs to be changed.\n",
129129
"\n",
130130
"### Table 2\n",
131-
"- List packages with cyclic dependencies"
131+
"- List packages with cyclic dependencies as an overview"
132132
]
133133
},
134134
{
@@ -150,7 +150,7 @@
150150
"metadata": {},
151151
"source": [
152152
"### Table 3\n",
153-
"- List packages with cyclic dependencies with every dependency in a separate row sorted by the easiest and most valuable to resolve"
153+
"- List packages with cyclic dependencies with every dependency in a separate row sorted by the easiest and most valuable resolvable dependency first"
154154
]
155155
},
156156
{
@@ -189,7 +189,7 @@
189189
"\n",
190190
"If there are a couple of methods that are used for a distinct purpose, those could be factored out into a separate interface. The original type can extended/implement the new interface so that there are no breaking changes. Then all the callers, that use only this group of methods, can be changed to the new interface.\n",
191191
"\n",
192-
"### Table 3\n",
192+
"### Table 4\n",
193193
"- List top 20 most used combinations of methods of larger Types that might benefit from *Interface Segregation*"
194194
]
195195
},
@@ -222,7 +222,7 @@
222222
"source": [
223223
"### Types that are used by multiple packages\n",
224224
"\n",
225-
"#### Table 4\n",
225+
"#### Table 5\n",
226226
"- List the top 20 packages that are used by the highest count of different packages "
227227
]
228228
},
@@ -246,7 +246,7 @@
246246
"source": [
247247
"### Packages that are used by multiple artifacts\n",
248248
"\n",
249-
"#### Table 5\n",
249+
"#### Table 6\n",
250250
"- List the top 20 artifacts that only use a few (compared to all existing) packages of another artifact"
251251
]
252252
},
@@ -270,7 +270,7 @@
270270
"source": [
271271
"### Packages that are used by multiple artifacts\n",
272272
"\n",
273-
"#### Table 6\n",
273+
"#### Table 7\n",
274274
"- List the top 20 packages that only use a few (compared to all existing) types of another package "
275275
]
276276
},

jupyter/VisibilityMetrics.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
"\n",
140140
"Non public classes can't be accessed from another package so they can be changed without affecting code in other packages. They clearly indicate functionality that only belongs to one package. This also motivates to use more classes and to split up code into smaller pieces with a single responsibility and reason to change.\n",
141141
"\n",
142-
"### Table 1\n",
142+
"### Table 2\n",
143143
"\n",
144144
"- Show relative visibility statistics aggregated for all packages per artifact "
145145
]
@@ -162,7 +162,7 @@
162162
"id": "3f59da8d",
163163
"metadata": {},
164164
"source": [
165-
"### Table 2\n",
165+
"### Table 3\n",
166166
"\n",
167167
"- List the top 40 packages and their artifact with the highest relative visibility"
168168
]

scripts/executeJupyterNotebook.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
# It it isn't activated, it will save the currently activated environment, change to codegraph, and restore the original one at the end again.
2020
# In cases of an error it might be, that the original conda environment isn't set back. Typically this shouldn't be the case though.
2121

22+
# Requires juypter nbconvert
23+
2224
SKIP_JUPYTER_NOTEBOOK_PDF_GENERATION=${SKIP_JUPYTER_NOTEBOOK_PDF_GENERATION:-""}
2325

2426
# Check if environment variable is set

scripts/executeQuery.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Overrideable Defaults
1717
NEO4J_HTTP_PORT=${NEO4J_HTTP_PORT:-"7474"}
18-
NEO4J_HTTP_TRANSACTION_ENDPOINT=${NEO4J_HTTP_TRANSACTION_ENDPOINT:-"db/neo4j/tx/commit"} # Neo4j v5: "db/<name>/tx/commit", Neo4j v4: "db/data/transaction/commit",
18+
NEO4J_HTTP_TRANSACTION_ENDPOINT=${NEO4J_HTTP_TRANSACTION_ENDPOINT:-"db/neo4j/tx/commit"} # Neo4j v5: "db/<name>/tx/commit", Neo4j v4: "db/data/transaction/commit"
1919

2020
# Check if environment variable is set
2121
if [ -z "${NEO4J_INITIAL_PASSWORD}" ]; then

0 commit comments

Comments
 (0)