Skip to content

Commit 68b659c

Browse files
committed
Improve error handling by writing to err out
1 parent 62ca6c8 commit 68b659c

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

scripts/executeQuery.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ NEO4J_HTTP_TRANSACTION_ENDPOINT=${NEO4J_HTTP_TRANSACTION_ENDPOINT:-"db/neo4j/tx/
1919

2020
# Check if environment variable is set
2121
if [ -z "${NEO4J_INITIAL_PASSWORD}" ]; then
22-
echo "Requires environment variable NEO4J_INITIAL_PASSWORD to be set first. Use 'export NEO4J_INITIAL_PASSWORD=<your-own-password>'."
22+
echo "Requires environment variable NEO4J_INITIAL_PASSWORD to be set first. Use 'export NEO4J_INITIAL_PASSWORD=<your-own-password>'." >&2
2323
exit 1
2424
fi
2525

@@ -29,9 +29,9 @@ no_source_reference=false
2929

3030
# Input Arguments: Function to print usage information
3131
print_usage() {
32-
echo "Usage: $0 <filename> [--no-source-reference-column]"
33-
echo "Options:"
34-
echo " --no-source-reference-column: Exclude the source reference column"
32+
echo "Usage: $0 <filename> [--no-source-reference-column]" >&2
33+
echo "Options:" >&2
34+
echo " --no-source-reference-column: Exclude the source reference column" >&2
3535
}
3636

3737
# Input Arguments: Parse the command-line arguments
@@ -51,12 +51,12 @@ while [[ $# -gt 0 ]]; do
5151

5252
# Input Arguments: Check the first input argument to be a valid file
5353
if [ ! -f "${cypher_query_file_name}" ] ; then
54-
echo "Error: Please provide a valid filename."
54+
echo "Error: Please provide a valid filename." >&2
5555
print_usage
5656
exit 1
5757
fi
5858
else
59-
echo "Error: Unknown option: $key"
59+
echo "Error: Unknown option: $key" >&2
6060
print_usage
6161
exit 1
6262
fi

scripts/executeQueryFunctions.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ execute_cypher_http_expect_results() {
5252
results=$( execute_cypher_http ${cypherFileName} | wc -l )
5353
results=$((results - 1))
5454
if [[ "$results" -lt 1 ]]; then
55-
echo "$(basename -- "${cypherFileName}") (via http) Error: Expected at least one entry but was ${results}"
55+
echo "$(basename -- "${cypherFileName}") (via http) Error: Expected at least one entry but was ${results}" >&2
5656
exit 1
5757
fi
5858
}
@@ -64,7 +64,7 @@ execute_cypher_shell() {
6464

6565
# Check if NEO4J_BIN exists
6666
if [ ! -d "${NEO4J_BIN}" ] ; then
67-
echo "executeQuery: Error: Neo4j Binary Directory <${NEO4J_BIN}> doesn't exist. Please run setupNeo4j.sh first."
67+
echo "executeQuery: Error: Neo4j Binary Directory <${NEO4J_BIN}> doesn't exist. Please run setupNeo4j.sh first." >&2
6868
exit 1
6969
fi
7070

@@ -95,7 +95,7 @@ execute_cypher_shell_expect_results() {
9595
results=$( execute_cypher_shell ${cypherFileName} | wc -l )
9696
results=$((results - 2))
9797
if [[ "$results" -lt 1 ]]; then
98-
echo "$(basename -- "${cypherFileName}") (via cypher-shell) Error: Expected at least one entry but was ${results}"
98+
echo "$(basename -- "${cypherFileName}") (via cypher-shell) Error: Expected at least one entry but was ${results}" >&2
9999
exit 1
100100
fi
101101
}

0 commit comments

Comments
 (0)