Skip to content

Commit 5f60f4d

Browse files
committed
Use pnpm as package manager for react-router.
The react-router project recently switched from yarn to pnpm which
1 parent ac4b6f2 commit 5f60f4d

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.github/workflows/typescript-code-analysis.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
distribution: 'adopt'
6666
java-version: ${{ matrix.java }}
6767

68-
- name: Setup Node.js for Graph Visualization
68+
- name: Setup Node.js
6969
uses: actions/setup-node@v4
7070
with:
7171
node-version-file: 'graph-visualization/.nvmrc'
@@ -112,6 +112,11 @@ jobs:
112112
key:
113113
${{ runner.os }}-${{ hashFiles('**/*.sh') }}
114114

115+
- name: Setup pnpm for react-router
116+
uses: pnpm/[email protected]
117+
with:
118+
version: 8.10.5
119+
115120
- name: Download ${{ env.PROJECT_NAME }}-${{ env.REACT_ROUTER_VERSION }}
116121
working-directory: temp
117122
run: |

scripts/downloader/downloadReactRouter.sh

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
# Note: This script is meant to be started within the temporary analysis directory (e.g. "temp/AnalysisName/")
1111

12+
# Note: react-router uses pnpm as package manager which needs to be installed
13+
1214
# Requires downloadMavenArtifact.sh
1315

1416
# Get the analysis name from the middle part of the current file name (without prefix "download" and without extension)
@@ -29,15 +31,18 @@ fi
2931
PROJECT_VERSION=$1
3032
echo "download${ANALYSIS_NAME}: PROJECT_VERSION=${PROJECT_VERSION}"
3133

34+
# Create runtime logs directory if it hasn't existed yet
35+
mkdir -p ./runtime/logs
36+
3237
################################################################
3338
# Download react-router source files to be analyzed
3439
################################################################
3540
git clone https://github.com/remix-run/react-router.git source
3641
(
3742
cd source || exit
3843
git checkout "react-router@${PROJECT_VERSION}"
39-
yarn install || yarn
40-
npx --yes @jqassistant/ts-lce >jqassostant-typescript-scan.log
44+
pnpm install --frozen-lockfile
45+
npx --yes @jqassistant/ts-lce >./../runtime/logs/jqassostant-typescript-scan.log 2>&1
4146
)
4247
mkdir -p artifacts
4348
mv -nv "source/.reports/jqa/ts-output.json" "artifacts/ts-react-router-${PROJECT_VERSION}.json"

0 commit comments

Comments
 (0)