fixup! Support executing Jupyter Notebooks on Windows

Author: JohT

scripts/executeJupyterNotebook.sh

@@ -19,7 +19,7 @@
 #       It it isn't activated, it will save the currently activated environment, change to codegraph, and restore the original one at the end again.
 #       In cases of an error it might be, that the original conda environment isn't set back. Typically this shouldn't be the case though. 
 
-# Requires juypter nbconvert
+# Requires juypter nbconvert,,operatingSystemFunctions.sh
 
 # Fail on any error ("-e" = exit on first error, "-o pipefail" exist on errors within piped commands)
 set -eo pipefail
@@ -85,24 +85,15 @@ backupCondaEnvironment=$CONDA_DEFAULT_ENV
 echo "executeJupyterNotebook: CODEGRAPH_CONDA_ENVIRONMENT=${CODEGRAPH_CONDA_ENVIRONMENT}"
 echo "executeJupyterNotebook: Current conda environment=${CONDA_DEFAULT_ENV}"
 
-isWindows=false
-if [[ "$OSTYPE" == "cygwin" ]] || [[ "$OSTYPE" == "msys" ]] || [[ "$OSTYPE" == "win32" ]]; then
-    isWindows=true
-    echo "executeJupyterNotebook: Detected isWindows=${isWindows} for operating system type ${OSTYPE}"
-fi
+# Include operation system function to for example detect Windows.
+source "${SCRIPTS_DIR}/operatingSystemFunctions.sh"
 
-scriptExtension=""
-if [[ "${isWindows}" = true ]]; then
-    scriptExtension=".bat"
-    echo "startNeo4j: Using scriptExtension ${scriptExtension} for Windows."
-fi
+scriptExtension=$(ifWindows ".bat" "")
 
 # Determine the path to "conda"
 if [ -n "${CONDA}" ]; then
-    if [[ "${isWindows}" = true ]]; then
+    if isWindows; then
         pathToConda="${CONDA}\\Scripts\\" # the trailing backslash character is required
-        PYTHONWARNINGS="ignore:Unverified HTTPS request"
-        echo "executeJupyterNotebook: Setting PYTHONWARNINGS=${PYTHONWARNINGS}"
     else
         pathToConda="${CONDA}/bin/" # the trailing slash character is required
     fi