Breaking rename RESOLVES_TO to IS_IMPLEMENTED_IN for Typescript modules.

Author: JohT

cypher/Dependencies_Projection/Dependencies_0_Verify_Projectable.cypher

@@ -7,7 +7,7 @@
       ,(dependency[$dependencies_projection_weight_property])             AS weightPropertyValue
       ,(dependency[$dependencies_projection_weight_property] < 1)         AS nonPositiveWeightPropertyValue
       ,coalesce(dependency.resolved, false)                               AS resolvedDependency
-      ,EXISTS { (target)<-[:RESOLVES_TO]-(resolvedTarget:ExternalModule) } AS resolvedTarget
+      ,EXISTS { (target)<-[:IS_IMPLEMENTED_IN]-(resolvedTarget:ExternalModule) } AS resolvedTarget
       ,(source.incomingDependencies IS NULL OR
         target.incomingDependencies IS NULL)   AS missingIncomingDependencies
       ,(source.outgoingDependencies IS NULL OR 

cypher/DependsOn_Relationship_Weights/Add_fine_grained_weights_for_Typescript_external_module_dependencies.cypher

@@ -4,8 +4,8 @@
  MATCH (source:TS:Module)-[moduleDependency:DEPENDS_ON]->(target:ExternalModule)
 // Exclude all targets where an ExternalModule was found that resolves to them
 // because those are covered in the fine grained weights for "ExternalModule"s.
- WHERE NOT EXISTS { (target)-[:RESOLVES_TO]->(source) }
-OPTIONAL MATCH (source)-[resolvedModuleDependency:DEPENDS_ON]->(resolvedTarget:TS:Module)<-[:RESOLVES_TO]-(target)
+ WHERE NOT EXISTS { (target)-[:IS_IMPLEMENTED_IN]->(source) }
+OPTIONAL MATCH (source)-[resolvedModuleDependency:DEPENDS_ON]->(resolvedTarget:TS:Module)<-[:IS_IMPLEMENTED_IN]-(target)
   WITH source
       ,target
       ,moduleDependency
@@ -24,7 +24,7 @@ OPTIONAL MATCH (source)-[rd:DEPENDS_ON]->(declaration:ExternalDeclaration)<-[:EX
       ,collect(declaration)                          AS declarations
 // Get optional low coupling elements (TypeAlias, Interface) that the source module contains and defines (low level) that depend on the external module (target)
 UNWIND declarations AS declaration
-OPTIONAL MATCH (source)-[ra:DEPENDS_ON]->(declaration)-[:RESOLVES_TO]->(abstractType:TypeAlias|Interface)
+OPTIONAL MATCH (source)-[ra:DEPENDS_ON]->(declaration)-[:IS_IMPLEMENTED_IN]->(abstractType:TypeAlias|Interface)
   WITH source
       ,target
       ,moduleDependency

cypher/DependsOn_Relationship_Weights/Add_fine_grained_weights_for_Typescript_internal_module_dependencies.cypher

@@ -7,7 +7,7 @@
  WHERE moduleDependency.declarationCount IS NULL
 // Ruling out resolved targets also filters out entries that aren't covered by the fine grained weights for "ExternalModule"s.
 // Therefore, the exists filter is commented out for now and replaced by focussing on missing detailed weight properties to catch them all.
-//WHERE NOT EXISTS { (target)<-[:RESOLVES_TO]-(resolvedTarget:ExternalModule) }
+//WHERE NOT EXISTS { (target)<-[:IS_IMPLEMENTED_IN]-(resolvedTarget:ExternalModule) }
   WITH source
       ,target
       ,moduleDependency

cypher/External_Dependencies/List_external_modules_resolved_to_internal_ones_for_Typescript.cypher

@@ -1,6 +1,6 @@
 // Statistics about how many ExternalModule nodes were found that match internal Module nodes 
 
- MATCH (module:TS:Module)<-[resolved:RESOLVES_TO]-(external:TS:ExternalModule)
+ MATCH (module:TS:Module)<-[resolved:IS_IMPLEMENTED_IN]-(external:TS:ExternalModule)
 OPTIONAL MATCH (project:TS:Project)-[:CONTAINS]->(module)
   WITH project.name                               AS projectName
       ,count(DISTINCT module)                     AS resolvedModuleCount

cypher/Metrics/Set_Outgoing_Typescript_Module_Dependencies.cypher

@@ -3,9 +3,9 @@
 // Get the top level dependency between a Typescript module and an external modules it uses
  MATCH (source:TS:Module)
 OPTIONAL MATCH (source)-[moduleDependency:DEPENDS_ON]->(target:ExternalModule)
- WHERE NOT EXISTS {(target)-[:RESOLVES_TO]->(source)}
+ WHERE NOT EXISTS {(target)-[:IS_IMPLEMENTED_IN]->(source)}
 // Get the project of the external module if available
-OPTIONAL MATCH (projectdir:Directory)<-[:HAS_ROOT]-(project:TS:Project)-[:CONTAINS]->(:TS:Module)<-[:RESOLVES_TO]-(target)
+OPTIONAL MATCH (projectdir:Directory)<-[:HAS_ROOT]-(project:TS:Project)-[:CONTAINS]->(:TS:Module)<-[:IS_IMPLEMENTED_IN]-(target)
 // Aggregate all gathered information for each (grouped by) source module
   WITH source
       ,collect(DISTINCT projectdir.absoluteFileName) AS projectNames

cypher/Typescript_Enrichment/Add_DEPENDS_ON_relationship_to_resolved_modules.cypher

@@ -2,7 +2,7 @@
 // Inspired by https://github.com/jQAssistant/jqassistant/blob/4cd7face5d6d2953449d8e6ff5b484f00ffbdc2f/plugin/java/src/main/resources/META-INF/jqassistant-rules/java-classpath.xml#L5
 
  MATCH (module:TS:Module)-[dependsOn:DEPENDS_ON]->(externalModule:TS:ExternalModule)
- MATCH (externalModule)-[:RESOLVES_TO]->(resolvedModule:TS:Module)
+ MATCH (externalModule)-[:IS_IMPLEMENTED_IN]->(resolvedModule:TS:Module)
  WHERE module <> resolvedModule
   CALL {  WITH module, dependsOn, resolvedModule
          MERGE (module)-[resolvedDependsOn:DEPENDS_ON]->(resolvedModule)

cypher/Typescript_Enrichment/Add_IS_IMPLEMENTED_IN_relationship_for_matching_declarations.cypher

@@ -1,7 +1,7 @@
 // Link matching external to internal Typescript declarations with an IS_IMPLEMENTED_IN relationship
 
  MATCH (externalModule:TS&ExternalModule)-[:EXPORTS]->(externalDeclaration:TS&ExternalDeclaration)
- MATCH (externalModule)-[:RESOLVES_TO]->(internalModule:TS&Module)
+ MATCH (externalModule)-[:IS_IMPLEMENTED_IN]->(internalModule:TS&Module)
  MATCH (externalModule)-[:EXPORTS]->(internalDeclaration:TS&!ExternalDeclaration)
  WHERE externalDeclaration.name = internalDeclaration.name
   WITH externalDeclaration, internalDeclaration

cypher/Typescript_Enrichment/Add_RESOLVES_TO_relationship_for_matching_modules.cypher renamed to cypher/Typescript_Enrichment/Add_IS_IMPLEMENTED_IN_relationship_for_matching_modules.cypher

@@ -1,4 +1,4 @@
-// Adds a relation "RESOLVES_TO" from an external module to a module if their global fully qualified names match.
+// Adds a relation "IS_IMPLEMENTED_IN" from an external module to a module if their global fully qualified names match.
 // Depends on "Add_module_properties.cypher" to be run first
 // Inspired by https://github.com/jQAssistant/jqassistant/blob/4cd7face5d6d2953449d8e6ff5b484f00ffbdc2f/plugin/java/src/main/resources/META-INF/jqassistant-rules/java-classpath.xml#L5
 // Related to https://github.com/jqassistant-plugin/jqassistant-typescript-plugin/issues/35
@@ -47,7 +47,7 @@ WHERE equalGlobalFqn
    OR equalNameWithoutNamespace
    OR equalNameAndNpmPackage
  CALL {  WITH module, externalModule
-        MERGE (externalModule)-[:RESOLVES_TO]->(module)
+        MERGE (externalModule)-[:IS_IMPLEMENTED_IN]->(module)
       } IN TRANSACTIONS
 RETURN CASE WHEN equalGlobalFqn            THEN 'equalGlobalFqn'
             WHEN equalModule               THEN 'equalModule'

cypher/Typescript_Enrichment/Count_internal_modules_resolving_external_ones.cypher

@@ -4,7 +4,7 @@
   WITH count(internal_module)   AS totalNumberOfInternalModules
       ,collect(internal_module) AS internal_modules
  UNWIND internal_modules AS internal_module
- MATCH (external_module:TS:ExternalModule)-[:RESOLVES_TO]->(internal_module)
+ MATCH (external_module:TS:ExternalModule)-[:IS_IMPLEMENTED_IN]->(internal_module)
  WHERE NOT external_module.isNodeModule = true
 RETURN totalNumberOfInternalModules
       ,COUNT { (all_external_modules:TS:ExternalModule) 

scripts/prepareAnalysis.sh

@@ -90,7 +90,7 @@ execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Link_external_modules_to_corresponding_
 execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Add_namespace_property_on_nodes_from_linked_npm_packages.cypher"
 
 # Preparation - Enrich Graph for Typescript by adding relationships between Modules with the same globalFqn
-execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Add_RESOLVES_TO_relationship_for_matching_modules.cypher"
+execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Add_IS_IMPLEMENTED_IN_relationship_for_matching_modules.cypher"
 execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Add_IS_IMPLEMENTED_IN_relationship_for_matching_declarations.cypher"
 execute_cypher "${TYPESCRIPT_CYPHER_DIR}/Add_DEPENDS_ON_relationship_to_resolved_modules.cypher"