Skip to content

Commit 0e50228

Browse files
JohTJohT
committed
Make weight setter language dependent
1 parent d4472b0 commit 0e50228

6 files changed

+19
-13
lines changed

‎cypher/Package_Relationship_Weights/Add_weight10PercentInterfaces_to_Package_DEPENDS_ON_relationships.cypher‎ renamed to ‎cypher/DependsOn_Relationship_Weights/Add_weight10PercentInterfaces_to_Java_Package_DEPENDS_ON_relationships.cypher‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Add weight10PercentInterfaces to Package DEPENDS_ON relationships
22

3-
MATCH (package:Package)-[r:DEPENDS_ON]->(dependent:Package)
3+
MATCH (package:Java:Package)-[r:DEPENDS_ON]->(dependent:Java:Package)
44
WITH package, r
55
,toInteger(r.weight - round(r.weightInterfaces * 0.90)) AS weight10PercentInterfaces
66
SET r.weight10PercentInterfaces = weight10PercentInterfaces

‎cypher/Package_Relationship_Weights/Add_weight25PercentInterfaces_to_Package_DEPENDS_ON_relationships.cypher‎ renamed to ‎cypher/DependsOn_Relationship_Weights/Add_weight25PercentInterfaces_to_Java_Package_DEPENDS_ON_relationships.cypher‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Add weight25PercentInterfaces to Package DEPENDS_ON relationships
22

3-
MATCH (package:Package)-[r:DEPENDS_ON]->(dependent:Package)
3+
MATCH (package:Java:Package)-[r:DEPENDS_ON]->(dependent:Java:Package)
44
WITH package, r
55
,toInteger(r.weight - round(r.weightInterfaces * 0.75)) AS weight25PercentInterfaces
66
SET r.weight25PercentInterfaces = weight25PercentInterfaces

‎cypher/Package_Relationship_Weights/Add_weight_property_for_Interface_Dependencies_to_Package_DEPENDS_ON_Relationship.cypher‎ renamed to ‎cypher/DependsOn_Relationship_Weights/Add_weight_property_for_Java_Interface_Dependencies_to_Package_DEPENDS_ON_Relationship.cypher‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Add weight property for Interface Dependencies to Package DEPENDS_ON Relationship
22

3-
MATCH (sourcePackage:Package)-[packageDependency:DEPENDS_ON]->(dependentPackage:Package)
3+
MATCH (sourcePackage:Java:Package)-[packageDependency:DEPENDS_ON]->(dependentPackage:Java:Package)
44
MATCH (sourcePackage)-[:CONTAINS]->(sourceType:Type)
55
OPTIONAL MATCH (sourceType:Type)-[typeDependency:DEPENDS_ON]->(dependentInterface:Interface)<-[:CONTAINS]-(dependentPackage)
66
WHERE sourcePackage.fqn <> dependentPackage.fqn

‎cypher/Package_Relationship_Weights/Add_weight_property_for_Low_Coupling_Dependencies_to_Typescript_Model_DEPENDS_ON_Relationships.cypher‎ renamed to ‎cypher/DependsOn_Relationship_Weights/Add_weight_property_for_Low_Coupling_Dependencies_to_Typescript_Model_DEPENDS_ON_Relationships.cypher‎

File renamed without changes.

‎cypher/Package_Relationship_Weights/Add_weight_property_to_Package_DEPENDS_ON_Relationship.cypher‎ renamed to ‎cypher/DependsOn_Relationship_Weights/Add_weight_property_to_Java_Package_DEPENDS_ON_Relationship.cypher‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Add weight property to Package DEPENDS_ON Relationship
22

3-
MATCH (sourcePackage:Package)-[:CONTAINS]->(sourceType:Type)-[typeDependency:DEPENDS_ON]->(dependentType:Type)<-[:CONTAINS]-(dependentPackage:Package)
3+
MATCH (sourcePackage:Java:Package)-[:CONTAINS]->(sourceType:Type)-[typeDependency:DEPENDS_ON]->(dependentType:Type)<-[:CONTAINS]-(dependentPackage:Java:Package)
44
MATCH (sourcePackage)-[packageDependency:DEPENDS_ON]->(dependentPackage)
55
WHERE sourcePackage.fqn <> dependentPackage.fqn
66
WITH packageDependency

‎scripts/prepareAnalysis.sh‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ source "${SCRIPTS_DIR}/executeQueryFunctions.sh"
3131
source "${SCRIPTS_DIR}/parseCsvFunctions.sh"
3232

3333
# Local Constants
34-
PACKAGE_WEIGHTS_CYPHER_DIR="$CYPHER_DIR/Package_Relationship_Weights"
34+
PACKAGE_WEIGHTS_CYPHER_DIR="$CYPHER_DIR/DependsOn_Relationship_Weights"
3535
PACKAGE_METRICS_CYPHER_DIR="$CYPHER_DIR/Metrics"
3636
EXTERNAL_DEPENDENCIES_CYPHER_DIR="$CYPHER_DIR/External_Dependencies"
3737
ARTIFACT_DEPENDENCIES_CYPHER_DIR="$CYPHER_DIR/Artifact_Dependencies"
@@ -52,15 +52,21 @@ execute_cypher "${CYPHER_DIR}/Create_index_for_full_qualified_type_name.cypher"
5252
# execute_cypher "${CYPHER_DIR}/Create_a_DEPENDS_ON_relationship_for_every_DEPENDS_ON_PACKAGE.cypher"
5353
# execute_cypher "${CYPHER_DIR}/Create_a_DEPENDS_ON_relationship_for_every_DEPENDS_ON_ARTIFACT.cypher"
5454

55-
# Preparation - Add weights to package DEPENDS_ON relationships
56-
execute_cypher_expect_results "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight_property_for_Interface_Dependencies_to_Package_DEPENDS_ON_Relationship.cypher"
57-
execute_cypher_expect_results "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight_property_to_Package_DEPENDS_ON_Relationship.cypher"
58-
execute_cypher_expect_results "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight25PercentInterfaces_to_Package_DEPENDS_ON_relationships.cypher"
59-
execute_cypher_expect_results "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight10PercentInterfaces_to_Package_DEPENDS_ON_relationships.cypher"
55+
# Preparation - Add weights to Typescript Module DEPENDS_ON relationships including "outgoingDependencies"
56+
execute_cypher "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight_property_for_Low_Coupling_Dependencies_to_Typescript_Model_DEPENDS_ON_Relationships.cypher"
6057

61-
# Preparation - Add Package node properties "incomingDependencies" and "outgoingDependencies"
62-
execute_cypher_expect_results "${PACKAGE_METRICS_CYPHER_DIR}/Set_Incoming_Package_Dependencies.cypher"
63-
execute_cypher_expect_results "${PACKAGE_METRICS_CYPHER_DIR}/Set_Outgoing_Package_Dependencies.cypher"
58+
# Preparation - Add weights to Java Package DEPENDS_ON relationships
59+
execute_cypher "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight_property_for_Java_Interface_Dependencies_to_Package_DEPENDS_ON_Relationship.cypher"
60+
execute_cypher "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight_property_to_Java_Package_DEPENDS_ON_Relationship.cypher"
61+
execute_cypher "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight25PercentInterfaces_to_Java_Package_DEPENDS_ON_relationships.cypher"
62+
execute_cypher "${PACKAGE_WEIGHTS_CYPHER_DIR}/Add_weight10PercentInterfaces_to_Java_Package_DEPENDS_ON_relationships.cypher"
63+
64+
# Preparation - Add Typescript Module node properties "incomingDependencies"
65+
# TODO
66+
67+
# Preparation - Add Java Package node properties "incomingDependencies" and "outgoingDependencies"
68+
execute_cypher "${PACKAGE_METRICS_CYPHER_DIR}/Set_Incoming_Java_Package_Dependencies.cypher"
69+
execute_cypher "${PACKAGE_METRICS_CYPHER_DIR}/Set_Outgoing_Java_Package_Dependencies.cypher"
6470

6571
# Preparation - Label external types and annotations
6672
# "external" means that there is no byte code available, not a primitive type and not a java type

0 commit comments

Comments
 (0)