Skip to content

Commit 3d7310d

Browse files
committed
scala: supporting mill files - minor CR changes
1 parent f2c1643 commit 3d7310d

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

scala/scala-api/src/icons/Icons.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ public interface Icons {
1717
Icon COMPILATION_CHARTS = getIcon("/org/jetbrains/plugins/scala/images/compilationCharts.svg", Icons.class);
1818

1919
Icon SCALA_FILE = getIcon("/org/jetbrains/plugins/scala/images/fileScala.svg", Icons.class);
20+
Icon MILL_FILE = getIcon("/org/jetbrains/plugins/scala/images/millFile.svg", Icons.class);
2021

2122
Icon ADD_CLAUSE = getIcon("/org/jetbrains/plugins/scala/images/addClause.svg", Icons.class);
2223
Icon REMOVE_CLAUSE = getIcon("/org/jetbrains/plugins/scala/images/removeClause.svg", Icons.class);
@@ -77,7 +78,4 @@ public interface Icons {
7778

7879
// X-Ray mode widget
7980
Icon PIN = getIcon("/org/jetbrains/plugins/scala/images/pin.svg", Icons.class);
80-
81-
// Mill file
82-
Icon MILL_FILE = getIcon("/org/jetbrains/plugins/scala/images/millFile.svg", Icons.class);
8381
}

scala/scala-impl/resources/messages/ScalaBundle.properties

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ copy.scala.type=Copy Scala Type
2222
### org/jetbrains/plugins/scala/actions/EditPackagePrefixAction.scala
2323
edit.package.prefix=Edit Package Prefix...
2424

25-
### org/jetbrains/plugins/scala/projectView/FileNode/ScalaFileNode
26-
scala.file.mill.extension=mill
27-
2825
### org/jetbrains/plugins/scala/actions/MakeExplicitAction.scala
2926
make.implicit.conversion.explicit.action.text=Make implicit conversion explicit
3027
make.implicit.conversion.explicit.action.description=Make implicit conversion explicit

scala/scala-impl/src/org/jetbrains/plugins/scala/projectView/package.scala

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,9 @@ package object projectView {
3434
}
3535

3636
private def isMillFile(file: ScalaFile):Boolean = {
37-
val psiFile = file.getContainingFile
38-
if (psiFile == null) return false
39-
val vf = psiFile.getVirtualFile
37+
val vf = file.getVirtualFile
4038
if (vf == null) return false
41-
val fileExt = FileUtilRt.getExtension(vf.getPath)
42-
val millExt = ScalaBundle.message("scala.file.mill.extension")
43-
fileExt == millExt
39+
FileUtilRt.extensionEquals(vf.getPath, "mill")
4440
}
4541
}
4642

0 commit comments

Comments
 (0)