Skip to content

Commit 85f579f

Browse files
Merge pull request #316 from Java-Discord/moon/email-fix
2 parents 80e34b7 + e4d29e8 commit 85f579f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ dependencies {
2626
implementation("com.google.code.gson:gson:2.9.0")
2727
implementation("org.yaml:snakeyaml:1.30")
2828
implementation("com.google.re2j:re2j:1.6")
29+
implementation("commons-validator:commons-validator:1.7")
2930

3031
implementation("ch.qos.logback:logback-classic:1.2.11")
3132
implementation("com.mashape.unirest:unirest-java:1.4.9")

src/main/java/net/javadiscord/javabot/systems/staff/self_roles/SelfRoleInteractionManager.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import net.javadiscord.javabot.command.Responses;
1919
import net.javadiscord.javabot.data.config.GuildConfig;
2020
import net.javadiscord.javabot.data.config.guild.ModerationConfig;
21+
import org.apache.commons.validator.routines.EmailValidator;
2122

2223
import java.time.Instant;
2324

@@ -27,8 +28,6 @@
2728
@Slf4j
2829
public class SelfRoleInteractionManager {
2930

30-
private final String EMAIL_PATTERN = "[\\w-]+@([\\w-]+\\.)+[\\w-]+";
31-
3231
/**
3332
* Handles all Button Interactions regarding the Self Role System.
3433
*
@@ -170,7 +169,7 @@ private WebhookMessageAction<Message> sendStaffSubmission(ModalInteractionEvent
170169
var emailOption = event.getValue("email");
171170
var timezoneOption = event.getValue("timezone");
172171
var extraRemarksOption = event.getValue("extra-remarks");
173-
if(!emailOption.getAsString().matches(EMAIL_PATTERN)) {
172+
if(!EmailValidator.getInstance().isValid(emailOption.getAsString())) {
174173
return Responses.error(event.getHook(), String.format("`%s` is not a valid Email-Address. Please try again.", emailOption.getAsString()));
175174
}
176175
Role role = event.getGuild().getRoleById(roleId);

0 commit comments

Comments
 (0)