Remove atomic emulation #1103
Merged
Remove atomic emulation #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/remove_atomic_emulation
branch
from
dc1d1c1 to
e8253e2
Compare
diptorupd
reviewed
Jul 26, 2023
diptorupd
force-pushed
the
feature/remove_atomic_emulation
branch
from
e8253e2 to
e751744
Compare
ZzEeKkAa
force-pushed
the
feature/remove_atomic_emulation
branch
from
e751744 to
743de4b
Compare
ZzEeKkAa
commented
Jul 27, 2023
ZzEeKkAa
force-pushed
the
feature/remove_atomic_emulation
branch
4 times, most recently
from
5eb17ca to
f323f73
Compare
Contributor
Author
|
This PR should unblock these checks: |
diptorupd
reviewed
Jul 31, 2023
diptorupd
reviewed
Jul 31, 2023
diptorupd
previously requested changes
Jul 31, 2023
Contributor
There was a problem hiding this comment.
The run_test.sh script in the conda-recipe directory should be updated as well.
The documentation page
https://github.com/IntelPython/numba-dpex/blob/main/docs/source/user_guide/kernel_programming/atomic-operations.rst should be updated as well.
Contributor
|
@ZzEeKkAa in a subsequent PR can you push changes to remove the dependency on spirv-tools? |
ZzEeKkAa
force-pushed
the
feature/remove_atomic_emulation
branch
from
f323f73 to
7d9bcca
Compare
Contributor
|
Documentation preview: show. |
ZzEeKkAa
force-pushed
the
feature/remove_atomic_emulation
branch
2 times, most recently
from
e28ea8b to
0f05392
Compare
Contributor
Author
|
#650 tested: > set NUMBA_DPPY_DEBUG=1
> dpbench -b gpairs -i numba_dpex_k run --no-skip-expected-failures
================ Benchmark GPairs (gpairs) ========================
================ implementation numba_dpex_k ========================
implementation: numba_dpex_k
framework: numba_dpex
framework version: 0.21.1+61.g7d9bcca0.dirty
input size: 8512
setup time: 219.6217ms (219621700 ns)
warmup time: 962.5928ms (962592800 ns)
teardown time: 101.4μs (101400 ns)
max execution times: 4.226ms (4226000 ns)
min execution times: 2.7134ms (2713400 ns)
median execution times: 3.15995ms (3159950 ns)
repeats: 10
preset: S
validated: Success |
Contributor
Author
|
#1068 tested: python test_1068.py
Using device ...
Device(level_zero:gpu:0)
Reduction sum = 11.
Done... |
diptorupd
force-pushed
the
feature/remove_atomic_emulation
branch
from
0f05392 to
167def8
Compare
Contributor
Author
Contributor
|
Documentation preview removed. |
Contributor
Author
Did it here in a separate commit. |
github-actions bot
added a commit
that referenced
this pull request
Aug 2, 2023
…tion Remove atomic emulation ead772d
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DPCPP now supports atomics, we don't need to emulate them by ourselves.
Fixes: #760
Fixes: #650
Fixes: #868
Fixes: #1068