Skip to content

Make CI more reliable #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

Make CI more reliable #1093

merged 2 commits into from
Jul 18, 2023

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jul 14, 2023 •
edited
Loading

Update is targeted to provide more reliable workflow that picks up all the latest dev dependencies:

  • Use conda-forge instead of pkgs/main
  • Use same workflow for linux and windows
  • Combine multiple github pages into one workflow file
  • Get rid of separate actions since they are not making workflow files more reliable
  • Docs does not have numba_dpex dependency now and that's make doc build much faster
  • Use mamba as package resolver for environment
  • Use conda mambabuild instead of conda build provided by boa for faster conda package build
  • Remove redundant cleanup for conda environment (for Windows it was taking more than a minute)
  • Improve general pipeline logic to check that conda package has all the required dependencies
  • Prevent multiple messages to appear for github documentation preview

PR checks:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jul 14, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 5 times, most recently from cfa5d1b to ed14f96 Compare July 14, 2023 17:32
diptorupd
diptorupd reviewed Jul 14, 2023
View reviewed changes
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 7 times, most recently from 2010451 to 28d3206 Compare July 14, 2023 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 28d3206 to f7c3ae8 Compare July 14, 2023 19:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from f7c3ae8 to accb8ce Compare July 14, 2023 20:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from accb8ce to 0176b04 Compare July 14, 2023 20:51
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 2 times, most recently from 7b934cc to a49f5ef Compare July 14, 2023 21:45
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from a49f5ef to 2f7d7a9 Compare July 15, 2023 02:48
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 2f7d7a9 to f0acf43 Compare July 17, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 4 times, most recently from 7c3f2ae to 398dde2 Compare July 18, 2023 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 398dde2 to 5f899f3 Compare July 18, 2023 15:12
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review July 18, 2023 15:52
@ZzEeKkAa ZzEeKkAa requested a review from mingjie-intel as a code owner July 18, 2023 15:52
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 5f899f3 to 802af6b Compare July 18, 2023 15:52
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 802af6b to e77e80f Compare July 18, 2023 15:53
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Documentation preview: show.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 3 times, most recently from 71b0ed4 to f1470e4 Compare July 18, 2023 16:02
@ZzEeKkAa ZzEeKkAa changed the title WIP: Make CI more reliable Make CI more reliable Jul 18, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from f1470e4 to 47e459b Compare July 18, 2023 16:55
diptorupd
diptorupd reviewed Jul 18, 2023
View reviewed changes
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch 3 times, most recently from 320885b to 4ec6a1b Compare July 18, 2023 21:09
@ZzEeKkAa ZzEeKkAa force-pushed the feature/make_ci_more_reliable branch from 4ec6a1b to 14a01d2 Compare July 18, 2023 21:11
diptorupd
diptorupd approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of changes. Thank you very much!

@diptorupd diptorupd merged commit 94cea55 into main Jul 18, 2023
@diptorupd diptorupd deleted the feature/make_ci_more_reliable branch July 18, 2023 21:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Documentation preview removed.

github-actions bot added a commit that referenced this pull request Jul 18, 2023
@github-actions
Merge pull request #1093 from IntelPython/feature/make_ci_more_reliable
15bb4be 
Make CI more reliable 94cea55
@ZzEeKkAa ZzEeKkAa mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzEeKkAa @diptorupd