Skip to content

Commit acacdbe

Browse files
author
Diptorup Deb
authored
Merge pull request #885 from IntelPython/pin_spirv_max_version
Set the max spirv version to 1.1
2 parents 9809c95 + 82ed599 commit acacdbe

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

numba_dpex/spirv_generator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ def generate(self, llvm_spirv_args, ipath, opath):
7575
if config.DEBUG:
7676
llvm_spirv_flags.append("--spirv-debug-info-version=ocl-100")
7777

78+
if not config.NATIVE_FP_ATOMICS:
79+
llvm_spirv_args = ["--spirv-max-version", "1.1"] + llvm_spirv_args
7880
llvm_spirv_tool = self._llvm_spirv()
7981

8082
if config.DEBUG:
@@ -94,7 +96,7 @@ def _llvm_spirv():
9496
# use llvm-spirv from dpcpp package.
9597
# assume dpcpp from .../bin folder.
9698
# assume llvm-spirv from .../bin-llvm folder.
97-
dpcpp_path = shutil.which("dpcpp")
99+
dpcpp_path = shutil.which("icx")
98100
if dpcpp_path is not None:
99101
bin_llvm = os.path.dirname(dpcpp_path) + "/../bin-llvm/"
100102
bin_llvm = os.path.normpath(bin_llvm)

setup.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,11 @@ def spirv_compile():
116116
]
117117
spirv_args = [
118118
_llvm_spirv(),
119+
"--spirv-max-version",
120+
"1.1",
121+
"numba_dpex/ocl/atomics/atomic_ops.bc",
119122
"-o",
120123
"numba_dpex/ocl/atomics/atomic_ops.spir",
121-
"numba_dpex/ocl/atomics/atomic_ops.bc",
122124
]
123125
subprocess.check_call(
124126
clang_args,
@@ -140,15 +142,14 @@ def _llvm_spirv():
140142

141143
result = None
142144

143-
if result is None:
144-
# use llvm-spirv from dpcpp package.
145-
# assume dpcpp from .../bin folder.
146-
# assume llvm-spirv from .../bin-llvm folder.
147-
dpcpp_path = shutil.which("dpcpp")
148-
if dpcpp_path is not None:
149-
bin_llvm = os.path.dirname(dpcpp_path) + "/../bin-llvm/"
150-
bin_llvm = os.path.normpath(bin_llvm)
151-
result = shutil.which("llvm-spirv", path=bin_llvm)
145+
# use llvm-spirv from dpcpp package.
146+
# assume dpcpp from .../bin folder.
147+
# assume llvm-spirv from .../bin-llvm folder.
148+
dpcpp_path = shutil.which("icx")
149+
if dpcpp_path is not None:
150+
bin_llvm = os.path.dirname(dpcpp_path) + "/../bin-llvm/"
151+
bin_llvm = os.path.normpath(bin_llvm)
152+
result = shutil.which("llvm-spirv", path=bin_llvm)
152153

153154
if result is None:
154155
result = "llvm-spirv"

0 commit comments

Comments
 (0)