Improve pairwise_distance workloads
#283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode84
force-pushed
the
pairwise-fixes
branch
from
bc11a35 to
7ac2c25
Compare
Contributor
Author
|
@diptorupd ping |
Contributor
Author
|
@diptorupd @ZzEeKkAa ping |
diptorupd
force-pushed
the
pairwise-fixes
branch
from
7ac2c25 to
acf0ab4
Compare
ZzEeKkAa
approved these changes
Jul 31, 2023
Contributor
ZzEeKkAa
left a comment
ZzEeKkAa
left a comment
There was a problem hiding this comment.
Code design looks good for me, but I don't have much context to review it on the logic perspective
* Use 2D dispatch in kernel impls instead of huge sequential inner loop. * Use nested prange in `numba_mlir_p` impl, `numba` and `numba-dpex` doesn't support nested pranges, but `numba-mlir` does. * Remove workaround in `numba_mlir_n`
Hardcode84
force-pushed
the
pairwise-fixes
branch
from
acf0ab4 to
de90464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numba_mlir_pimpl,numbaandnumba-dpexdoesn't support nested pranges, butnumba-mlirdoes.numba_mlir_n