Skip to content

Conversation

@tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Aug 18, 2022

Partially ports ITK module template build-test-package.yml Github Action specification as a composite action that can be referenced by other projects in relation to InsightSoftwareConsortium/ITKModuleTemplate#131.

Notes:

  • This is a first pass and will be tagged as a prerelease. Documentation indicates that the composite action cannot be tested in isolation, it may be necessary to pull this into main first and then test with a remote module development branch. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
  • A composite action runs in sequence and cannot run multiple jobs. As such this composite action only aims to address cxx building and testing. A separate repo and .yml file will be required for Python build/test/packaging.

EDIT: I am able to reference the development branch commit hash for testing in InsightSoftwareConsortium/ITKSplitComponents#60

@tbirdso tbirdso requested review from jcfr and thewtex August 18, 2022 15:33
@tbirdso
Copy link
Collaborator Author

tbirdso commented Aug 18, 2022

All cxx tests are passing in ITKSplitComponents development branch calling this action

InsightSoftwareConsortium/ITKSplitComponents#60

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Request inline

@tbirdso
Copy link
Collaborator Author

tbirdso commented Aug 19, 2022

Hi @thewtex , I do not see your requested change?

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbirdso not sure how the comment was lost, but added again.

@tbirdso tbirdso force-pushed the add-build-config-yml branch 3 times, most recently from bca7a74 to 60c1373 Compare August 22, 2022 14:12
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbirdso yes this works 👍

Adds a composite action to drive common cxx build+test CI actions for
ITK remote module repositories.

Partially addresses
InsightSoftwareConsortium/ITKModuleTemplate#131.
@tbirdso tbirdso force-pushed the add-build-config-yml branch from 60c1373 to 2ed6d19 Compare August 23, 2022 12:52
@tbirdso
Copy link
Collaborator Author

tbirdso commented Aug 23, 2022

Squashed commits.

@tbirdso tbirdso merged commit a6f55fb into main Aug 23, 2022
@jhlegarreta jhlegarreta deleted the add-build-config-yml branch August 24, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants