USD PointInstancerAlgo : Remove unnecessary GetTimeSamples() call

johnhaddon · johnhaddon · commit 47b5d7758cb1 · 2024-10-24T11:54:24.000+01:00
We're not using the result anywhere. I assume this was an early attempt at ignoring unauthored values, eventually replaced by the code below.
diff --git a/contrib/IECoreUSD/src/IECoreUSD/PointInstancerAlgo.cpp b/contrib/IECoreUSD/src/IECoreUSD/PointInstancerAlgo.cpp
@@ -86,8 +86,6 @@ IECore::ObjectPtr readPointInstancer( pxr::UsdGeomPointInstancer &pointInstancer
 	Canceller::check( canceller );
 	PrimitiveAlgo::readPrimitiveVariable( pointInstancer.GetAngularVelocitiesAttr(), time, newPoints.get(), "angularVelocity" );
 
-	std::vector<double> times;
-	pointInstancer.GetInvisibleIdsAttr().GetTimeSamples( &times );
 	if( pointInstancer.GetInvisibleIdsAttr().HasAuthoredValue() )
 	{
 		DataPtr cortexInvisIds = DataAlgo::fromUSD( pointInstancer.GetInvisibleIdsAttr(), time, true );

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,6 @@ IECore::ObjectPtr readPointInstancer( pxr::UsdGeomPointInstancer &pointInstancer`
`86`	`86`	`Canceller::check( canceller );`
`87`	`87`	`PrimitiveAlgo::readPrimitiveVariable( pointInstancer.GetAngularVelocitiesAttr(), time, newPoints.get(), "angularVelocity" );`
`88`	`88`
`89`		`- std::vector<double> times;`
`90`		`- pointInstancer.GetInvisibleIdsAttr().GetTimeSamples( &times );`
`91`	`89`	`if( pointInstancer.GetInvisibleIdsAttr().HasAuthoredValue() )`
`92`	`90`	`{`
`93`	`91`	`DataPtr cortexInvisIds = DataAlgo::fromUSD( pointInstancer.GetInvisibleIdsAttr(), time, true );`