[Forwardport] Add 'const' type support to layout arguments #1

IgorVitol · 2018-05-20T10:14:21Z

Original Pull Request

Description

For now in Magento we can not use xsi:type="const" in layout arguments. But it looks like such ability can be very useful. Moreover such code already exists in Magento core, we just need to include/enable it.

Manual testing scenarios

Add argument with "const" type to any block via layout arguments. For example like this:

<referenceBlock name="product.info.sku">
    <arguments>
        <argument name="my_const_value" xsi:type="const">Magento\Catalog\Api\Data\ProductAttributeInterface::ENTITY_TYPE_CODE</argument>
    </arguments>
</referenceBlock>

Verify that it is correctly passed to block constructor. Like here: http://prntscr.com/jf7qa0

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…ighted and Combined upon Checkout page load magento#975

…o#921

…tion <var name='allowfullscreen'>false</var> for mobile device don't work in product view page gallery magento#15021 - Merge Pull Request magento#15021 from gwharton/magento2:2.3-develop-12285 - Merged commits: 1. 435b165 2. 4113f26 3. c0b9e8f 4. 05b1512 5. 2701a4f

…ready have the latest version magento#15034 - Merge Pull Request magento#15034 from DanielRuf/magento2:2.3-develop-PR-port-15012 - Merged commits: 1. b76ddf8 2. 40d9180

…ER BY part). magento#1003

…pr18

…O-90182-Bundle-Child-Index

…pr18

- reload product properly

…y' into team3-delivery

- added jsDoc

…TWO-90563

… fix

…pr18

…yPal Express checkout magento#15050 - Merge Pull Request magento#15050 from rogyar/magento2:2.3-duplicate-paypal-email-fix - Merged commits: 1. b6e2ad0

…low app:config:import magento#15051 - Merge Pull Request magento#15051 from rogyar/magento2:2.3-config-import-country-cart - Merged commits: 1. e07e762

- merged latest code from mainline branch

@mzeis

Accepted Public Pull Requests: - magento#15128: [Forwardport] chore: use random_int() in some places (by @mzeis)

- creating a class to hide from printing needed elements

…oding styles doesn't work for PageBuilder code - add modules to whitelist to enable static test `\Magento\Test\Less\LiveCodeTest`

…to#15198

…te in its name magento#15186

…agento#15185

…ttings magento#15161

…15168

…lay as "No" of the storefront - type check safety added for boolean vs string/int on dropdown that was causing this bug

[Performance] [2.3 Forwardport] Performance of Category Products index is slow when you have big number of categories

- merged latest code from mainline branch

@seruymt

Accepted Public Pull Requests: - magento#15198: MSI: Remove MultiDimensionalIndexer from framework (by @seruymt) - magento#15186: [Forwardport] Fixed js error when product has double quote in its name (by @mzeis) - magento#15185: [Forwardport] Removed unused class declaration and code (by @dmytro-ch) - magento#15161: 2.3 Development: Clarify XSD for formElements allowed settings (by @RNanoware) - magento#15168: [Port 2.3-develop] Add parent item to order item (by @JeroenVanLeusden) - magento#15082: [Forwardport] Fixed Overlay Problems (by @adrian-martinez-interactiv4) Fixed GitHub Issues: - magento#14140: UI component definition.map.xml overlooks XSD-valid nodes (reported by @RNanoware) has been fixed in magento#15161 by @RNanoware in 2.3-develop branch Related commits: 1. 2d75f25 2. b32a33a 3. 56c7609 4. 64adba9 5. 0750a16 6. 214ae8b 7. 5a323af

…lay as "No" of the storefront - static fix

…roduct-attributes-of-dropdown

…0-Empty-product-attributes-of-dropdown

…oding styles doesn't work for modules - fix static integrity test

…7592-static-test-less Fixed issues: - MAGETWO-87592 Static test - investigate why existing test for LESS coding styles doesn't work for PageBuilder code

…ont if it is empty for the Product - added test

… installation - added functional test

…ttps://github.com/magento-honey-badgers/magento2ce into MAGETWO-91580-Empty-product-attributes-of-dropdown

…ont if it is empty for the Product - added clean up steps and updated Data file

…0-Empty-product-attributes-of-dropdown

…580-Empty-product-attributes-of-dropdown [honey] Bug fixes

gwharton and others added 30 commits May 6, 2018 21:58

Fix Travis Long Line Check

2701a4f

Merge branch '2.3-develop' into MAGETWO-90294

5a03730

Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-90293

c7f3884

Merge branch '2.3-develop' into MAGETWO-90294

2c12090

MAGETWO-90292: 8410: Custom Checkout Step and Shipping Step are Highl…

a477ee2

…ighted and Combined upon Checkout page load magento#975

MAGETWO-90285: 8830: Can`t delete row in dynamicRows component magent…

6a11839

…o#921

fix: set message-success in setup if we already have the latest version

b76ddf8

fix: break line into multiple lines to fix PHPCS violation

40d9180

ENGCOM-1460: [Forwardport] fix: set message-success in setup if we al…

1bb694b

…ready have the latest version magento#15034 - Merge Pull Request magento#15034 from DanielRuf/magento2:2.3-develop-PR-port-15012 - Merged commits: 1. b76ddf8 2. 40d9180

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-pr17

3eaa11f

MAGETWO-90297: 5738: SearchCriteriaBuilder builds wrong criteria (ORD…

05eee1c

…ER BY part). magento#1003

Merge remote-tracking branch 'origin/MAGETWO-75125' into 2.3-develop-…

6c7a22a

…pr18

Merge remote-tracking branch 'origin/MAGETWO-90293' into 2.3-develop-…

2bc87e0

…pr18

Merge remote-tracking branch 'remotes/origin/2.3-develop' into MAGETW…

c06d26b

…O-90182-Bundle-Child-Index

Merge remote-tracking branch 'origin/MAGETWO-90292' into 2.3-develop-…

ad60d4d

…pr18

DEVOPS-2174: Fix integration tests

9f13c1a

Merge remote-tracking branch 'mainline/2.3-develop' into DEVOPS-2174

2c2f8f8

MAGETWO-90182: Alter option saving mechanism

24a90b9

- reload product properly

chore: upgrade Node.js to 8

68c0462

Merge branch 'MAGETWO-90241' into team3-delivery

e6b689f

Merge branch 'MAGETWO-90177-Image-Broken-on-Storefront-with-Secure-Ke…

a12ce50

…y' into team3-delivery

MAGETWO-90878: Build stabilization

b7a6cab

- added jsDoc

Merge branch '2.3-develop' of github.com:magento/magento2ce into MAGE…

dbf74dc

…TWO-90563

Duplicate Order Confirmation Emails for PayPal Express checkout order…

b6e2ad0

… fix

Add statement to 'beforeSave' method to allow app:config:import

e07e762

Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-90388

9e4a521

Merge remote-tracking branch 'origin/MAGETWO-90388' into 2.3-develop-…

0654e74

…pr18

ENGCOM-1468: [Forwardport] Duplicate Order Confirmation Emails for Pa…

beb0baa

…yPal Express checkout magento#15050 - Merge Pull Request magento#15050 from rogyar/magento2:2.3-duplicate-paypal-email-fix - Merged commits: 1. b6e2ad0

ENGCOM-1469: [Forwardport] Add statement to 'beforeSave' method to al…

c94472a

…low app:config:import magento#15051 - Merge Pull Request magento#15051 from rogyar/magento2:2.3-config-import-country-cart - Merged commits: 1. e07e762

magento-engcom-team and others added 28 commits May 15, 2018 16:30

[EngCom] Public Pull Requests - 2.3-develop

1b6e9d6

- merged latest code from mainline branch

🔃 [EngCom] Public Pull Requests - 2.3-develop

14f7b06

Accepted Public Pull Requests: - magento#15128: [Forwardport] chore: use random_int() in some places (by @mzeis)

merge magento/2.3-develop into magento-performance/MAGETWO-91114

c7e118c

MAGETWO-91575: Print page of compare page is not correctly aligned

f03e784

- creating a class to hide from printing needed elements

MAGETWO-87592: Static test - investigate why existing test for LESS c…

af960ed

…oding styles doesn't work for PageBuilder code - add modules to whitelist to enable static test `\Magento\Test\Less\LiveCodeTest`

ENGCOM-1550: MSI: Remove MultiDimensionalIndexer from framework magen…

c58d200

…to#15198

ENGCOM-1548: [Forwardport] Fixed js error when product has double quo…

c00d32c

…te in its name magento#15186

ENGCOM-1545: [Forwardport] Removed unused class declaration and code m…

e106261

…agento#15185

ENGCOM-1541: 2.3 Development: Clarify XSD for formElements allowed se…

f2b8d9b

…ttings magento#15161

ENGCOM-1532: [Port 2.3-develop]Add parent item to order item magento#…

8ecf7a1

…15168

ENGCOM-1490: [Forwardport] Fixed Overlay Problems magento#15082

5dc7409

MAGETWO-90569: Empty product attributes of dropdown/swatch types disp…

730d0c9

…lay as "No" of the storefront - type check safety added for boolean vs string/int on dropdown that was causing this bug

Merge pull request magento#2542 from magento-performance/MAGETWO-91114

7769546

[Performance] [2.3 Forwardport] Performance of Category Products index is slow when you have big number of categories

[EngCom] Public Pull Requests - 2.3-develop

18872d0

- merged latest code from mainline branch

MAGETWO-90569: Empty product attributes of dropdown/swatch types disp…

86aa6e3

…lay as "No" of the storefront - static fix

Merge branch 'MAGETWO-91575-print-compare' into MAGETWO-91580-Empty-p…

e902c80

…roduct-attributes-of-dropdown

Merge remote-tracking branch 'mainline/2.3-develop' into MAGETWO-9158…

e498c26

…0-Empty-product-attributes-of-dropdown

Merge branch '2.3-develop' into MAGETWO-87592-static-test-less

bf68656

MAGETWO-87592: Static test - investigate why existing test for LESS c…

401abaf

…oding styles doesn't work for modules - fix static integrity test

Merge pull request magento#2551 from magento-obsessive-owls/MAGETWO-8…

fb4294a

…7592-static-test-less Fixed issues: - MAGETWO-87592 Static test - investigate why existing test for LESS coding styles doesn't work for PageBuilder code

MAGETWO-91893: Verify the product attribute is not visible on storefr…

6c799ec

…ont if it is empty for the Product - added test

MAGETWO-91409: Rush theme not available on Themes Grid with clean 2.3…

527fbbb

… installation - added functional test

Merge branch 'MAGETWO-91580-Empty-product-attributes-of-dropdown' of h…

ae911c1

…ttps://github.com/magento-honey-badgers/magento2ce into MAGETWO-91580-Empty-product-attributes-of-dropdown

MAGETWO-91893: Verify the product attribute is not visible on storefr…

aad5111

…ont if it is empty for the Product - added clean up steps and updated Data file

Merge remote-tracking branch 'mainline/2.3-develop' into MAGETWO-9158…

25b2780

…0-Empty-product-attributes-of-dropdown

Merge pull request magento#2556 from magento-honey-badgers/MAGETWO-91…

e65dac4

…580-Empty-product-attributes-of-dropdown [honey] Bug fixes

Add 'const' type support to layout arguments

c9215e5

IgorVitol force-pushed the 2.3-develop-PR-port-15058 branch from aefa0e6 to c9215e5 Compare May 20, 2018 10:17

IgorVitol closed this May 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Forwardport] Add 'const' type support to layout arguments #1

[Forwardport] Add 'const' type support to layout arguments #1

Uh oh!

IgorVitol commented May 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

44 participants

[Forwardport] Add 'const' type support to layout arguments #1

[Forwardport] Add 'const' type support to layout arguments #1

Uh oh!

Conversation

IgorVitol commented May 20, 2018

Original Pull Request

Description

Manual testing scenarios

Contribution checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

44 participants