HubSpot Backport: HBASE-28842 TestRequestAttributes should fail when expected (apache#6255) (apache#6287) (#119)

eab148 · rmdmattingly · Evie Boland · web-flow · commit 1498df499038 · 2024-10-04T14:46:42.000-04:00
Signed-off-by: Ray Mattingly &lt;rmattingly@apache.org&gt;
Signed-off-by: Nick Dimiduk &lt;ndimiduk@apache.org&gt;
Co-authored-by: Ray Mattingly &lt;rmattingly@apache.org&gt;
Co-authored-by: Evie Boland &lt;eboland@hubspot.com&gt;
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRequestAttributes.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRequestAttributes.java
@@ -352,8 +352,7 @@ private Map<String, byte[]> getRequestAttributesForRowKey(byte[] rowKey) {
       return null;
     }
 
-    private boolean isValidRequestAttributes(Map<String, byte[]> requestAttributes)
-      throws IOException {
+    private boolean isValidRequestAttributes(Map<String, byte[]> requestAttributes) {
       RpcCall rpcCall = RpcServer.getCurrentCall().get();
       Map<String, byte[]> attrs = rpcCall.getRequestAttributes();
       if (attrs.size() != requestAttributes.size()) {

Original file line number	Diff line number	Diff line change
`@@ -352,8 +352,7 @@ private Map<String, byte[]> getRequestAttributesForRowKey(byte[] rowKey) {`
`352`	`352`	`return null;`
`353`	`353`	`}`
`354`	`354`
`355`		`- private boolean isValidRequestAttributes(Map<String, byte[]> requestAttributes)`
`356`		`- throws IOException {`
	`355`	`+ private boolean isValidRequestAttributes(Map<String, byte[]> requestAttributes) {`
`357`	`356`	`RpcCall rpcCall = RpcServer.getCurrentCall().get();`
`358`	`357`	`Map<String, byte[]> attrs = rpcCall.getRequestAttributes();`
`359`	`358`	`if (attrs.size() != requestAttributes.size()) {`