implement some pmd hints

Author: rbri

src/main/java/com/gargoylesoftware/htmlunit/HttpWebConnection.java

@@ -340,7 +340,7 @@ else if (webRequest.getEncodingType() == FormEncodingType.TEXT_PLAIN && method i
                     final StringBuilder body = new StringBuilder();
                     for (final NameValuePair pair : webRequest.getRequestParameters()) {
                         body.append(StringUtils.remove(StringUtils.remove(pair.getName(), '\r'), '\n'))
-                            .append("=")
+                            .append('=')
                             .append(StringUtils.remove(StringUtils.remove(pair.getValue(), '\r'), '\n'))
                             .append("\r\n");
                     }

src/main/java/com/gargoylesoftware/htmlunit/WebWindowEvent.java

@@ -142,10 +142,10 @@ else if (object1 == null || object2 == null) {
      */
     @Override
     public String toString() {
-        final StringBuilder builder = new StringBuilder(80);
-        builder.append("WebWindowEvent(source=[");
-        builder.append(getSource());
-        builder.append("] type=[");
+        final StringBuilder builder = new StringBuilder(80)
+            .append("WebWindowEvent(source=[")
+            .append(getSource())
+            .append("] type=[");
         switch (type_) {
             case OPEN:
                 builder.append("OPEN");
@@ -160,11 +160,11 @@ public String toString() {
                 builder.append(type_);
                 break;
         }
-        builder.append("] oldPage=[");
-        builder.append(getOldPage());
-        builder.append("] newPage=[");
-        builder.append(getNewPage());
-        builder.append("])");
+        builder.append("] oldPage=[")
+            .append(getOldPage())
+            .append("] newPage=[")
+            .append(getNewPage())
+            .append("])");
 
         return builder.toString();
     }

src/main/java/com/gargoylesoftware/htmlunit/html/DomNode.java

@@ -929,13 +929,14 @@ public <T> T getScriptableObject() {
             if (this == page) {
                 final StringBuilder msg = new StringBuilder("No script object associated with the Page.");
                 // because this is a strange case we like to provide as many info as possible
-                msg.append(" class: '");
-                msg.append(page.getClass().getName());
-                msg.append('\'');
+                msg.append(" class: '")
+                    .append(page.getClass().getName())
+                    .append('\'');
                 try {
-                    msg.append(" url: '").append(page.getUrl()).append('\'');
-                    msg.append(" content: ");
-                    msg.append(page.getWebResponse().getContentAsString());
+                    msg.append(" url: '")
+                        .append(page.getUrl()).append('\'')
+                        .append(" content: ")
+                        .append(page.getWebResponse().getContentAsString());
                 }
                 catch (final Exception e) {
                     // ok bad luck with detail

src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElement.java

@@ -400,9 +400,9 @@ public String getNodeName() {
         final String prefix = getPrefix();
         if (prefix != null) {
             // create string builder only if needed (performance)
-            final StringBuilder name = new StringBuilder(prefix.toLowerCase(Locale.ROOT));
-            name.append(':');
-            name.append(getLocalName().toLowerCase(Locale.ROOT));
+            final StringBuilder name = new StringBuilder(prefix.toLowerCase(Locale.ROOT))
+                .append(':')
+                .append(getLocalName().toLowerCase(Locale.ROOT));
             return name.toString();
         }
         return getLocalName().toLowerCase(Locale.ROOT);

src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLDocument.java

@@ -441,12 +441,12 @@ else if (currentChar == '\\') {
         }
         if (scriptTagCount > 0 || tagState != ParsingStatus.OUTSIDE) {
             if (LOG.isDebugEnabled()) {
-                final StringBuilder message = new StringBuilder();
-                message.append("canAlreadyBeParsed() retruns false for content: '");
-                message.append(StringUtils.abbreviateMiddle(content, ".", 100));
-                message.append("' (scriptTagCount: " + scriptTagCount);
-                message.append(" tagState: " + tagState);
-                message.append(')');
+                final StringBuilder message = new StringBuilder()
+                    .append("canAlreadyBeParsed() retruns false for content: '")
+                    .append(StringUtils.abbreviateMiddle(content, ".", 100))
+                    .append("' (scriptTagCount: " + scriptTagCount)
+                    .append(" tagState: " + tagState)
+                    .append(')');
                 LOG.debug(message.toString());
             }
             return false;

src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElement.java

@@ -484,9 +484,9 @@ public String getLocalName() {
             final String prefix = domNode.getPrefix();
             if (prefix != null) {
                 // create string builder only if needed (performance)
-                final StringBuilder localName = new StringBuilder(prefix.toLowerCase(Locale.ROOT));
-                localName.append(':');
-                localName.append(domNode.getLocalName().toLowerCase(Locale.ROOT));
+                final StringBuilder localName = new StringBuilder(prefix.toLowerCase(Locale.ROOT))
+                    .append(':')
+                    .append(domNode.getLocalName().toLowerCase(Locale.ROOT));
                 return localName.toString();
             }
             return domNode.getLocalName().toLowerCase(Locale.ROOT);

src/main/java/com/gargoylesoftware/htmlunit/javascript/regexp/HtmlUnitRegExpProxy.java

@@ -178,16 +178,15 @@ private String doStringReplacement(final String originalString,
 
         final StaticStringMatcher matcher = new StaticStringMatcher(originalString, searchString);
         if (matcher.start() > -1) {
-            final StringBuilder sb = new StringBuilder();
-            sb.append(originalString.substring(0, matcher.start_));
+            final StringBuilder sb = new StringBuilder()
+                .append(originalString, 0, matcher.start_);
 
             String localReplacement = replacement;
             if (replacement.contains("$")) {
                 localReplacement = computeReplacementValue(localReplacement, originalString, matcher, false);
             }
-
-            sb.append(localReplacement);
-            sb.append(originalString.substring(matcher.end_));
+            sb.append(localReplacement)
+                .append(originalString, matcher.end_, originalString.length());
             return sb.toString();
         }
         return originalString;

src/test/java/com/gargoylesoftware/htmlunit/CodeStyleTest.java

@@ -802,10 +802,10 @@ private static List<String> alertsToList(final String string) {
 
                 if (!insideString && token.contains("}")) {
                     final int curlyIndex = token.indexOf('}') + 1;
-                    currentToken.append(token.substring(0, curlyIndex));
+                    currentToken.append(token, 0, curlyIndex);
                     list.add(currentToken.toString());
                     currentToken.setLength(0);
-                    currentToken.append(token.substring(curlyIndex));
+                    currentToken.append(token, curlyIndex, token.length());
                 }
                 else {
                     if (!insideString && token.contains(",") && !startsWithBraces) {

src/test/java/com/gargoylesoftware/htmlunit/NotYetImplementedTest.java

@@ -175,7 +175,7 @@ private static String getDescription(final List<String> lines, final int index)
                 if (builder.length() != 0) {
                     builder.append(' ');
                 }
-                builder.append(line.substring(start, line.length() - (end ? 2 : 0)));
+                builder.append(line, start, line.length() - (end ? 2 : 0));
             }
             if (end) {
                 break;

src/test/java/com/gargoylesoftware/htmlunit/javascript/SimpleScriptable2Test.java

@@ -197,7 +197,7 @@ public void dateGetTimezoneOffset() throws Exception {
         final int minutes = Integer.parseInt(strMinutes);
         final StringBuilder sb = new StringBuilder();
         if (minutes != 0) {
-            sb.append(hour.substring(1));
+            sb.append(hour, 1, hour.length());
             strMinutes = String.valueOf((double) minutes / 60);
             strMinutes = strMinutes.substring(1);
             sb.append(strMinutes);