Fix favicon for Google, add favicon for Apple devices #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerCed
approved these changes
Jan 25, 2025
…le for favicon, add favicon for apple devices
C0NZZ
force-pushed
the
fix-favicon-for-google
branch
from
acb1a05 to
a74ea2c
Compare
C0NZZ
force-pushed
the
fix-favicon-for-google
branch
from
a74ea2c to
139d61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google, as noted here, requires favicons to be square. To comply, I updated the favicon reference to use the existing square
favicon.pngand updated the file to feature the generic HackHPI logo instead of the 2024 logo.For Apple devices, as explained here, the favicon must be explicitly referenced as "apple-touch-icon" to be recognized. I added this reference accordingly.