Make Instances<T>::default() always return an empty table

Author: Keavon

node-graph/gcore/src/instances.rs

@@ -119,17 +119,13 @@ impl<T> Instances<T> {
 	}
 }
 
-impl<T: Default + Hash + 'static> Default for Instances<T> {
+impl<T> Default for Instances<T> {
 	fn default() -> Self {
-		// TODO: Remove once all types have been converted to tables
-		let converted_to_tables = [TypeId::of::<crate::Artboard>(), TypeId::of::<crate::GraphicElement>()];
-
-		use core::any::TypeId;
-		if converted_to_tables.contains(&TypeId::of::<T>()) {
-			// TODO: Remove the 'static trait bound when this special casing is removed by making all types return empty
-			Self::empty()
-		} else {
-			Self::new(T::default())
+		Self {
+			instance: Vec::new(),
+			transform: Vec::new(),
+			alpha_blending: Vec::new(),
+			source_node_id: Vec::new(),
 		}
 	}
 }

node-graph/gcore/src/vector/vector_nodes.rs

@@ -1732,14 +1732,14 @@ fn bevel(_: impl Ctx, source: VectorDataTable, #[default(10.)] distance: Length)
 
 #[node_macro::node(category("Vector"), path(graphene_core::vector))]
 fn close_path(_: impl Ctx, source: VectorDataTable) -> VectorDataTable {
-	let mut new_table = VectorDataTable::empty();
+	let mut result_table = VectorDataTable::empty();
 
 	for mut source_instance in source.instance_iter() {
 		source_instance.instance.close_subpaths();
-		new_table.push(source_instance);
+		result_table.push(source_instance);
 	}
 
-	new_table
+	result_table
 }
 
 #[node_macro::node(category("Vector"), path(graphene_core::vector))]

node-graph/gstd/src/filter.rs

@@ -19,6 +19,7 @@ async fn blur(
 	gamma: bool,
 ) -> ImageFrameTable<Color> {
 	let mut result_table = ImageFrameTable::empty();
+
 	for mut image_instance in image_frame.instance_iter() {
 		let image = image_instance.instance.clone();
 
@@ -36,6 +37,7 @@ async fn blur(
 		image_instance.source_node_id = None;
 		result_table.push(image_instance);
 	}
+
 	result_table
 }
 

node-graph/gstd/src/gpu_nodes.rs

@@ -36,6 +36,7 @@ async fn compile_gpu<'a: 'n>(_: impl Ctx, node: &'a DocumentNode, typing_context
 #[node_macro::node(category("Debug: GPU"))]
 async fn blend_gpu_image(_: impl Ctx, foreground: ImageFrameTable<Color>, background: ImageFrameTable<Color>, blend_mode: BlendMode, opacity: f64) -> ImageFrameTable<Color> {
 	let mut result_table = ImageFrameTable::empty();
+
 	for (foreground_instance, mut background_instance) in foreground.instance_iter().zip(background.instance_iter()) {
 		let foreground_transform = foreground_instance.transform;
 		let background_transform = background_instance.transform;
@@ -215,6 +216,7 @@ async fn blend_gpu_image(_: impl Ctx, foreground: ImageFrameTable<Color>, backgr
 		background_instance.source_node_id = None;
 		result_table.push(background_instance);
 	}
+
 	result_table
 }