Skip to content

Commit 2e24e2b

Browse files
committed
Fix tests
1 parent ece87db commit 2e24e2b

File tree

11 files changed

+19
-17
lines changed

11 files changed

+19
-17
lines changed

editor/src/messages/portfolio/document/document_message_handler.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2124,7 +2124,7 @@ impl DocumentMessageHandler {
21242124
/// Create a network interface with a single export
21252125
fn default_document_network_interface() -> NodeNetworkInterface {
21262126
let mut network_interface = NodeNetworkInterface::default();
2127-
network_interface.add_export(TaggedValue::ArtboardGroup(graphene_core::ArtboardGroup::EMPTY), -1, "", &[]);
2127+
network_interface.add_export(TaggedValue::ArtboardGroup(graphene_core::ArtboardGroup::default()), -1, "", &[]);
21282128
network_interface
21292129
}
21302130

editor/src/messages/portfolio/document/graph_operation/utility_types.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ impl<'a> ModifyInputsContext<'a> {
126126
/// Creates an artboard as the primary export for the document network
127127
pub fn create_artboard(&mut self, new_id: NodeId, artboard: Artboard) -> LayerNodeIdentifier {
128128
let artboard_node_template = resolve_document_node_type("Artboard").expect("Node").node_template_input_override([
129-
Some(NodeInput::value(TaggedValue::ArtboardGroup(graphene_std::ArtboardGroup::EMPTY), true)),
129+
Some(NodeInput::value(TaggedValue::ArtboardGroup(graphene_std::ArtboardGroup::default()), true)),
130130
Some(NodeInput::value(TaggedValue::GraphicGroup(graphene_core::GraphicGroupTable::default()), true)),
131131
Some(NodeInput::value(TaggedValue::IVec2(artboard.location), false)),
132132
Some(NodeInput::value(TaggedValue::IVec2(artboard.dimensions), false)),

editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {
310310
..Default::default()
311311
}),
312312
inputs: vec![
313-
NodeInput::value(TaggedValue::ArtboardGroup(ArtboardGroup::EMPTY), true),
313+
NodeInput::value(TaggedValue::ArtboardGroup(ArtboardGroup::default()), true),
314314
NodeInput::value(TaggedValue::GraphicGroup(GraphicGroupTable::default()), true),
315315
NodeInput::value(TaggedValue::IVec2(glam::IVec2::ZERO), false),
316316
NodeInput::value(TaggedValue::IVec2(glam::IVec2::new(1920, 1080)), false),

editor/src/messages/tool/tool_messages/path_tool.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ impl PathToolData {
502502
});
503503

504504
// Make handles colinear if opposite handle is zero length
505-
if opposite_handle_length.map_or(false, |l| l == 0.) {
505+
if opposite_handle_length == Some(0.) {
506506
shape_editor.convert_selected_manipulators_to_colinear_handles(responses, document);
507507
return true;
508508
}

node-graph/gcore/src/graphic_element.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,6 @@ pub struct ArtboardGroup {
350350
}
351351

352352
impl ArtboardGroup {
353-
pub const EMPTY: Self = Self { artboards: Vec::new() };
354-
355353
pub fn new() -> Self {
356354
Default::default()
357355
}

node-graph/gcore/src/graphic_element/renderer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use crate::transform::{Footprint, Transform};
99
use crate::uuid::{generate_uuid, NodeId};
1010
use crate::vector::style::{Fill, Stroke, ViewMode};
1111
use crate::vector::{PointId, VectorDataTable};
12-
use crate::{AlphaBlending, Artboard, ArtboardGroup, Color, GraphicElement, GraphicGroup, GraphicGroupTable, RasterFrame};
12+
use crate::{Artboard, ArtboardGroup, Color, GraphicElement, GraphicGroup, GraphicGroupTable, RasterFrame};
1313

1414
use bezier_rs::Subpath;
1515
use dyn_any::DynAny;
@@ -978,7 +978,7 @@ impl GraphicElementRendered for RasterFrame {
978978
fn render_to_vello(&self, scene: &mut Scene, transform: DAffine2, context: &mut RenderContext) {
979979
use vello::peniko;
980980

981-
let mut render_stuff = |image: vello::peniko::Image, blend_mode: AlphaBlending| {
981+
let mut render_stuff = |image: vello::peniko::Image, blend_mode: crate::AlphaBlending| {
982982
let image_transform = transform * self.transform() * DAffine2::from_scale(1. / DVec2::new(image.width as f64, image.height as f64));
983983
let layer = blend_mode != Default::default();
984984

node-graph/gcore/src/raster/adjustments.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,7 +1698,7 @@ async fn color_overlay<F: 'n + Send, T: Adjust<Color>>(
16981698

16991699
#[cfg(test)]
17001700
mod test {
1701-
use crate::raster::image::ImageFrame;
1701+
use crate::raster::image::{ImageFrame, ImageFrameTable};
17021702
use crate::raster::{BlendMode, Image};
17031703
use crate::{Color, Node};
17041704
use std::pin::Pin;
@@ -1721,18 +1721,17 @@ mod test {
17211721
image: Image::new(1, 1, image_color),
17221722
..Default::default()
17231723
};
1724-
let expected = result.image.data[0].clone();
1725-
let image_frame_table = ImageFrameTable::new(image);
17261724

17271725
// Color { red: 0., green: 1., blue: 0., alpha: 1. }
17281726
let overlay_color = Color::GREEN;
17291727

17301728
// 100% of the output should come from the multiplied value
17311729
let opacity = 100_f64;
17321730

1733-
let result = super::color_overlay((), &FutureWrapperNode(image), overlay_color, BlendMode::Multiply, opacity).await;
1731+
let result = super::color_overlay((), &FutureWrapperNode(ImageFrameTable::new(image.clone())), overlay_color, BlendMode::Multiply, opacity).await;
1732+
let result = result.one_item();
17341733

17351734
// The output should just be the original green and alpha channels (as we multiply them by 1 and other channels by 0)
1736-
assert_eq!(expected, Color::from_rgbaf32_unchecked(0., image_color.g(), 0., image_color.a()));
1735+
assert_eq!(result.image.data[0], Color::from_rgbaf32_unchecked(0., image_color.g(), 0., image_color.a()));
17371736
}
17381737
}

node-graph/gcore/src/vector/vector_nodes.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1503,7 +1503,7 @@ mod test {
15031503
let mut vector_data = VectorData::from_subpath(source);
15041504
let transform = DAffine2::from_scale_angle_translation(DVec2::splat(10.), 1., DVec2::new(99., 77.));
15051505
vector_data.transform = transform;
1506-
let beveled = super::bevel(Footprint::default(), &FutureWrapperNode(vector_data), 5.).await;
1506+
let beveled = super::bevel(Footprint::default(), &FutureWrapperNode(VectorDataTable::new(vector_data)), 5.).await;
15071507
let beveled = beveled.one_item();
15081508

15091509
assert_eq!(beveled.point_domain.positions().len(), 4);

node-graph/gstd/src/gpu_nodes.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ use graph_craft::document::*;
55
use graph_craft::proto::*;
66
use graphene_core::application_io::ApplicationIo;
77
use graphene_core::raster::image::{ImageFrame, ImageFrameTable};
8-
use graphene_core::raster::*;
8+
use graphene_core::raster::BlendMode;
9+
use graphene_core::raster::Image;
10+
use graphene_core::raster::Pixel;
911
use graphene_core::*;
1012
use wgpu_executor::{Bindgroup, PipelineLayout, Shader, ShaderIO, ShaderInput, WgpuExecutor, WgpuShaderInput};
1113

node-graph/gstd/src/image_color_palette.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ mod test {
7676
use super::*;
7777

7878
use graph_craft::generic::FnNode;
79-
use graphene_core::{raster::Image, value::CopiedNode, Node};
79+
use graphene_core::raster::image::{ImageFrame, ImageFrameTable};
80+
use graphene_core::raster::Image;
81+
use graphene_core::value::CopiedNode;
82+
use graphene_core::Node;
8083

8184
#[test]
8285
fn test_image_color_palette() {

0 commit comments

Comments
 (0)