refactor

Author: Byron

gix-object/tests/encode/mod.rs

@@ -95,3 +95,26 @@ mod blob {
     // It doesn't matter which data we use - it's not interpreted.
     round_trip!(gix_object::Blob, gix_object::BlobRef, "tree/everything.tree");
 }
+
+mod loose_header {
+    use bstr::ByteSlice;
+    use gix_object::{decode, encode, Kind};
+
+    #[test]
+    fn round_trip() -> Result<(), Box<dyn std::error::Error>> {
+        for (kind, size, expected) in &[
+            (Kind::Tree, 1234, "tree 1234\0".as_bytes()),
+            (Kind::Blob, 0, b"blob 0\0"),
+            (Kind::Commit, 24241, b"commit 24241\0"),
+            (Kind::Tag, 9999999999, b"tag 9999999999\0"),
+        ] {
+            let buf = encode::loose_header(*kind, *size);
+            assert_eq!(buf.as_bstr(), expected.as_bstr());
+            let (actual_kind, actual_size, actual_read) = decode::loose_header(&buf)?;
+            assert_eq!(actual_kind, *kind);
+            assert_eq!(actual_size, *size);
+            assert_eq!(actual_read, buf.len());
+        }
+        Ok(())
+    }
+}

gix-object/tests/loose/mod.rs

@@ -4,7 +4,7 @@ use gix_hash::ObjectId;
 
 mod encode;
 mod immutable;
-mod loose;
+mod object_ref;
 
 #[test]
 fn compute_hash() {

gix-object/tests/object.rs

@@ -0,0 +1,11 @@
+mod from_loose {
+    use gix_object::ObjectRef;
+
+    #[test]
+    fn shorter_than_advertised() {
+        assert_eq!(
+            ObjectRef::from_loose(b"tree 1000\x00").unwrap_err().to_string(),
+            "object data was shorter than its size declared in the header"
+        );
+    }
+}