From 861e00d46963e4a3dc3004570dc1aea11ca9d5ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samy=20Pess=C3=A9?= Date: Fri, 28 Feb 2025 10:18:06 +0100 Subject: [PATCH 1/2] Improve error message for image resizing --- packages/gitbook/src/routes/image.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/gitbook/src/routes/image.ts b/packages/gitbook/src/routes/image.ts index 4900f2ba15..79d0c8d725 100644 --- a/packages/gitbook/src/routes/image.ts +++ b/packages/gitbook/src/routes/image.ts @@ -45,7 +45,10 @@ export async function serveResizedImage(request: Request) { { signature, version: signatureVersion } ); if (!verified) { - return new Response(`Invalid signature "${signature ?? ''}" for "${url}"`, { status: 400 }); + return new Response( + `Invalid signature "${signature ?? ''}" (version ${signatureVersion}) for "${url}" on "${requestURL.host}"`, + { status: 400 } + ); } if (signatureVersion !== CURRENT_SIGNATURE_VERSION) { From f9fc185d2d1cad8456733e61748ec6b4a55c723e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samy=20Pess=C3=A9?= Date: Fri, 28 Feb 2025 10:21:28 +0100 Subject: [PATCH 2/2] Add host to image resize url --- packages/gitbook-v2/src/lib/images/createImageResizer.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/gitbook-v2/src/lib/images/createImageResizer.ts b/packages/gitbook-v2/src/lib/images/createImageResizer.ts index a437647cbe..72a2aaecd5 100644 --- a/packages/gitbook-v2/src/lib/images/createImageResizer.ts +++ b/packages/gitbook-v2/src/lib/images/createImageResizer.ts @@ -66,6 +66,7 @@ export function createImageResizer({ linker.toAbsoluteURL(linker.toPathInContent('/~gitbook/image')) ); url.searchParams.set('url', getImageAPIUrl(urlInput)); + url.searchParams.set('host', host); if (options.width) { url.searchParams.set('width', options.width.toString());