Cache keys fixes #951
Merged
Cache keys fixes #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ootProjectDirectory
…ject root directory
…ption contains expected message
This reverts commit 7a2e309.
…nfigFileSelection
When /overrideconfig presents version must be calculated explicitly without saving in cache.
Ensures that overriden config will be applied whenever there cached version exists and willn't save results in cache
…Branches Will be eventually corrupted back after applying Resharper's clean code. Will need to do smth with it.
Extracted cache key calculation to GitVersionCacheKeyFactory
…e code that doesn't fear Reshaper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #892 rebased with a few tests fixed after the rebase. Doing a new PR so I can make sure travis build also succeeds