Improved GitVersionTask documentation #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more information to how GitVersionTask works, a little TL;DR section and rewrote a few section to make the documentation clearer.
docs/usage/msbuild-task.md
Outdated
|
|
||
| Ensure you remove the `Assembly*Version` attributes from your `Properties\AssemblyInfo.cs` file so as to not get duplicate attribute warnings. Sample default: | ||
| At build time a temporary `AssemblyInfo.cs` will be created that contains the appropriate SemVer information. | ||
| This will will be included in the build pipeline. Sample default: |
Member
|
@asbjornu looks good, just a couple small comments. If you can fix up, I can merge it in. Thanks! |
Member
Author
|
@gep13 Thanks for the review. Everything should be fixed. |
Member
|
LGTM! Thanks! |
gep13
added a commit
that referenced
this pull request
Feb 23, 2016
Improved GitVersionTask documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more information to how GitVersionTask works, a little TL;DR section and rewrote a few section to make the documentation clearer. Addresses #789.