Skip to content

Introducing a new templating mechanism to support different workflows #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 1, 2023
Merged

Introducing a new templating mechanism to support different workflows #3409

merged 6 commits into from
Mar 1, 2023

Conversation

@HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Feb 28, 2023 •
edited
Loading

Introducing a new templating mechanism to support different workflows

Closes #3305

Description

Related Issue

#3305

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

arturcic
arturcic reviewed Feb 28, 2023
View reviewed changes
arturcic
arturcic reviewed Mar 1, 2023
View reviewed changes
@arturcic
Copy link
Member

arturcic commented Mar 1, 2023

Please also rebase on main

@HHobeck HHobeck force-pushed the feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows branch from bc6829d to 1207827 Compare March 1, 2023 07:38
arturcic
arturcic approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HHobeck
Copy link
Contributor Author

HHobeck commented Mar 1, 2023

I'm just thinking about to add a trunc based workflow to the WorkflowManager. Do you know how the configuration should look like?

https://gitversion.net/docs/learn/branching-strategies/

@arturcic
Copy link
Member

arturcic commented Mar 1, 2023

I think @asbjornu can have a better answer to your question

@arturcic
Copy link
Member

arturcic commented Mar 1, 2023

some info I found https://www.atlassian.com/continuous-delivery/continuous-integration/trunk-based-development

@arturcic
Copy link
Member

arturcic commented Mar 1, 2023

I think we can merge this one, and later you can have a new PR with the trunk based workflow? Agree?

@arturcic arturcic merged commit 23502ec into GitTools:main Mar 1, 2023
@arturcic arturcic deleted the feature/3305_introducing_a_new_templating_mechanism_to_support_different_workflows branch March 1, 2023 09:49
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

Thank you @HHobeck for your contribution!

@arturcic
Copy link
Member

arturcic commented Mar 1, 2023

@HHobeck please create a PR with the trunk based workflow when you figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturcic arturcic arturcic approved these changes

@asbjornu asbjornu Awaiting requested review from asbjornu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Introducing a new templating mechanism to support different workflows

2 participants

@HHobeck @arturcic