Skip to content

Avoid set-env environment warning during build log generation #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Avoid set-env environment warning during build log generation #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88d72bc
Avoid set-env environment warning during build log generation
danielmarbach Oct 9, 2020
824a3d2
Merge branch 'master' into patch-1
asbjornu Oct 13, 2020
61558c3
Merge branch 'master' into patch-1
arturcic Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/GitVersionCore.Tests/BuildAgents/GitHubActionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public void GetCurrentBranchShouldHandlePullRequests()
}

[TestCase("Something", "1.0.0",
"::set-env name=GitVersion_Something::1.0.0")]
"\"GitVersion_Something=1.0.0\" >> $GITHUB_ENV")]
public void GetSetParameterMessage(string key, string value, string expectedResult)
{
// Assert
Expand Down Expand Up @@ -141,7 +141,7 @@ public void ShouldWriteIntegration()
"Executing GenerateSetVersionMessage for 'GitHubActions'.",
"",
"Executing GenerateBuildLogOutput for 'GitHubActions'.",
"::set-env name=GitVersion_Major::1.0.0"
"\"GitVersion_Major=1.0.0\" >> $GITHUB_ENV"
};

string.Join(Environment.NewLine, list)
Expand Down
6 changes: 3 additions & 3 deletions src/GitVersionCore/BuildAgents/GitHubActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ public override string GenerateSetVersionMessage(VersionVariables variables)

public override string[] GenerateSetParameterMessage(string name, string value)
{
// https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-an-environment-variable-set-env
// https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
// Example
// echo "::set-env name=action_state::yellow"
// echo "name=action_state::yellow >> $GITHUB_ENV"

if (!string.IsNullOrWhiteSpace(value))
{
var key = $"GitVersion_{name}";

return new[]
{
$"::set-env name={key}::{value}"
$"\"{key}={value}\" >> $GITHUB_ENV"
};
}

Expand Down