Merge pull request #2422 from danielmarbach/patch-1

Avoid set-env environment warning during build log generation

Author: asbjornu

src/GitVersionCore.Tests/BuildAgents/GitHubActionsTests.cs

@@ -97,7 +97,7 @@ public void GetCurrentBranchShouldHandlePullRequests()
         }
 
         [TestCase("Something", "1.0.0",
-            "::set-env name=GitVersion_Something::1.0.0")]
+            "\"GitVersion_Something=1.0.0\" >> $GITHUB_ENV")]
         public void GetSetParameterMessage(string key, string value, string expectedResult)
         {
             // Assert
@@ -141,7 +141,7 @@ public void ShouldWriteIntegration()
                 "Executing GenerateSetVersionMessage for 'GitHubActions'.",
                 "",
                 "Executing GenerateBuildLogOutput for 'GitHubActions'.",
-                "::set-env name=GitVersion_Major::1.0.0"
+                "\"GitVersion_Major=1.0.0\" >> $GITHUB_ENV"
             };
 
             string.Join(Environment.NewLine, list)

src/GitVersionCore/BuildAgents/GitHubActions.cs

@@ -23,17 +23,17 @@ public override string GenerateSetVersionMessage(VersionVariables variables)
 
         public override string[] GenerateSetParameterMessage(string name, string value)
         {
-            // https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-an-environment-variable-set-env
+            // https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
             // Example
-            // echo "::set-env name=action_state::yellow"
+            // echo "name=action_state::yellow >> $GITHUB_ENV"
 
             if (!string.IsNullOrWhiteSpace(value))
             {
                 var key = $"GitVersion_{name}";
 
                 return new[]
                 {
-                    $"::set-env name={key}::{value}"
+                    $"\"{key}={value}\" >> $GITHUB_ENV"
                 };
             }