#3166 - drop .net core 3.1 support

arturcic · arturcic · commit 8428d404172c · 2022-10-16T13:10:38.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -225,7 +225,7 @@ jobs:
     strategy:
       matrix:
         targetFramework: [ '6.0' ]
-        distro: [ alpine.3.12, alpine.3.13, alpine.3.14, centos.7, centos.8, debian.9, debian.10, debian.11, fedora.33, ubuntu.18.04, ubuntu.20.04, ubuntu.22.04 ]
+        distro: [ alpine.3.13, alpine.3.14, centos.7, centos.8, debian.10, debian.11, fedora.33, ubuntu.18.04, ubuntu.20.04, ubuntu.22.04 ]
       fail-fast: false
 
     steps:
@@ -289,7 +289,7 @@ jobs:
     strategy:
       matrix:
         targetFramework: [ '6.0' ]
-        distro: [ alpine.3.12, alpine.3.13, alpine.3.14, centos.7, centos.8, debian.9, debian.10, debian.11, fedora.33, ubuntu.18.04, ubuntu.20.04, ubuntu.22.04 ]
+        distro: [ alpine.3.13, alpine.3.14, centos.7, centos.8, debian.10, debian.11, fedora.33, ubuntu.18.04, ubuntu.20.04, ubuntu.22.04 ]
       fail-fast: false
 
     steps:
diff --git a/build/artifacts/Tasks/ArtifactsDotnetToolTest.cs b/build/artifacts/Tasks/ArtifactsDotnetToolTest.cs
@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;
 [TaskDescription("Tests the dotnet global tool in docker container")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [IsDependentOn(typeof(ArtifactsPrepare))]
 public class ArtifactsDotnetToolTest : FrostingTask<BuildContext>
 {
diff --git a/build/artifacts/Tasks/ArtifactsMsBuildCoreTest.cs b/build/artifacts/Tasks/ArtifactsMsBuildCoreTest.cs
@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;
 [TaskDescription("Tests the msbuild package in docker container")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [IsDependentOn(typeof(ArtifactsPrepare))]
 public class ArtifactsMsBuildCoreTest : FrostingTask<BuildContext>
 {
diff --git a/build/artifacts/Tasks/ArtifactsNativeTest.cs b/build/artifacts/Tasks/ArtifactsNativeTest.cs
@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;
 [TaskDescription("Tests the native executables in docker container")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [IsDependentOn(typeof(ArtifactsPrepare))]
 public class ArtifactsNativeTest : FrostingTask<BuildContext>
 {
diff --git a/build/artifacts/Tasks/ArtifactsPrepare.cs b/build/artifacts/Tasks/ArtifactsPrepare.cs
@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;
 [TaskDescription("Pulls the docker images needed for testing the artifacts")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 public class ArtifactsPrepare : FrostingTask<BuildContext>
 {
     public override bool ShouldRun(BuildContext context)
diff --git a/build/artifacts/Tasks/ArtifactsTest.cs b/build/artifacts/Tasks/ArtifactsTest.cs
@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;
 [TaskDescription("Tests packages in docker container")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [IsDependentOn(typeof(ArtifactsNativeTest))]
 [IsDependentOn(typeof(ArtifactsDotnetToolTest))]
 [IsDependentOn(typeof(ArtifactsMsBuildCoreTest))]
diff --git a/build/common/Utilities/Constants.cs b/build/common/Utilities/Constants.cs
@@ -11,7 +11,7 @@ public class Constants
 
     public static readonly string[] VersionsToBuild = { Version60 };
     public static readonly Architecture[] ArchToBuild = { Architecture.Amd64, Architecture.Arm64 };
-    public static readonly string[] DistrosToSkip = { Alpine312, Alpine313, Alpine314, Centos7 };
+    public static readonly string[] DistrosToSkip = { Alpine313, Alpine314, Centos7 };
 
     public const string DockerBaseImageName = "gittools/build-images";
     public const string DockerImageName = "gittools/gitversion";
@@ -24,12 +24,10 @@ public class Constants
     public const string Arm64 = "arm64";
     public const string Amd64 = "amd64";
 
-    public const string Alpine312 = "alpine.3.12";
     public const string Alpine313 = "alpine.3.13";
     public const string Alpine314 = "alpine.3.14";
     public const string Centos7 = "centos.7";
     public const string Centos8 = "centos.8";
-    public const string Debian9 = "debian.9";
     public const string Debian10 = "debian.10";
     public const string Debian11 = "debian.11";
     public const string Fedora33 = "fedora.33";
@@ -39,12 +37,10 @@ public class Constants
     public const string DockerDistroLatest = Debian10;
     public static readonly string[] DockerDistrosToBuild =
     {
-        Alpine312,
         Alpine313,
         Alpine314,
         Centos7,
         Centos8,
-        Debian9,
         Debian10,
         Debian11,
         Fedora33,
diff --git a/build/docker/Tasks/DockerBuild.cs b/build/docker/Tasks/DockerBuild.cs
@@ -6,7 +6,7 @@ namespace Docker.Tasks;
 [TaskDescription("Build the docker images containing the GitVersion Tool")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [TaskArgument(Arguments.Architecture, Constants.Amd64, Constants.Arm64)]
 public class DockerBuild : FrostingTask<BuildContext>
 {
diff --git a/build/docker/Tasks/DockerManifest.cs b/build/docker/Tasks/DockerManifest.cs
@@ -6,7 +6,7 @@ namespace Docker.Tasks;
 [TaskDescription("Publish the docker manifest containing the images for amd64 and arm64")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [IsDependentOn(typeof(DockerManifestInternal))]
 public class DockerManifest : FrostingTask<BuildContext>
 {
diff --git a/build/docker/Tasks/DockerPublish.cs b/build/docker/Tasks/DockerPublish.cs
@@ -6,7 +6,7 @@ namespace Docker.Tasks;
 [TaskDescription("Publish the docker images containing the GitVersion Tool")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [TaskArgument(Arguments.Architecture, Constants.Amd64, Constants.Arm64)]
 [IsDependentOn(typeof(DockerPublishInternal))]
 public class DockerPublish : FrostingTask<BuildContext>
diff --git a/build/docker/Tasks/DockerTest.cs b/build/docker/Tasks/DockerTest.cs
@@ -6,7 +6,7 @@ namespace Docker.Tasks;
 [TaskDescription("Test the docker images containing the GitVersion Tool")]
 [TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]
 [TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]
-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]
+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]
 [TaskArgument(Arguments.Architecture, Constants.Amd64, Constants.Arm64)]
 [IsDependentOn(typeof(DockerBuild))]
 public class DockerTest : FrostingTask<BuildContext>

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;`
`6`	`6`	`[TaskDescription("Tests the dotnet global tool in docker container")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`[IsDependentOn(typeof(ArtifactsPrepare))]`
`11`	`11`	`public class ArtifactsDotnetToolTest : FrostingTask<BuildContext>`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;`
`6`	`6`	`[TaskDescription("Tests the msbuild package in docker container")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`[IsDependentOn(typeof(ArtifactsPrepare))]`
`11`	`11`	`public class ArtifactsMsBuildCoreTest : FrostingTask<BuildContext>`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;`
`6`	`6`	`[TaskDescription("Tests the native executables in docker container")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`[IsDependentOn(typeof(ArtifactsPrepare))]`
`11`	`11`	`public class ArtifactsNativeTest : FrostingTask<BuildContext>`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Artifacts.Tasks;`
`6`	`6`	`[TaskDescription("Pulls the docker images needed for testing the artifacts")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`public class ArtifactsPrepare : FrostingTask<BuildContext>`
`11`	`11`	`{`
`12`	`12`	`public override bool ShouldRun(BuildContext context)`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Docker.Tasks;`
`6`	`6`	`[TaskDescription("Build the docker images containing the GitVersion Tool")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`[TaskArgument(Arguments.Architecture, Constants.Amd64, Constants.Arm64)]`
`11`	`11`	`public class DockerBuild : FrostingTask<BuildContext>`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Docker.Tasks;`
`6`	`6`	`[TaskDescription("Publish the docker manifest containing the images for amd64 and arm64")]`
`7`	`7`	`[TaskArgument(Arguments.DockerRegistry, Constants.DockerHub, Constants.GitHub)]`
`8`	`8`	`[TaskArgument(Arguments.DockerDotnetVersion, Constants.Version60)]`
`9`		`-[TaskArgument(Arguments.DockerDistro, Constants.Alpine312, Constants.Debian10, Constants.Ubuntu2004)]`
	`9`	`+[TaskArgument(Arguments.DockerDistro, Constants.Alpine313, Constants.Debian10, Constants.Ubuntu2004)]`
`10`	`10`	`[IsDependentOn(typeof(DockerManifestInternal))]`
`11`	`11`	`public class DockerManifest : FrostingTask<BuildContext>`
`12`	`12`	`{`