cleanup

Author: arturcic

src/Directory.Build.props

@@ -1,7 +1,5 @@
 <Project>
     <PropertyGroup>
-        <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
-
         <Authors>GitTools and Contributors</Authors>
         <Copyright>Copyright GitTools 2021.</Copyright>
         <Company>$(Authors)</Company>
@@ -35,7 +33,6 @@
         <PackageVersion_NSubstitute>4.2.2</PackageVersion_NSubstitute>
         <PackageVersion_CoverletMsBuild>3.0.2</PackageVersion_CoverletMsBuild>
         <PackageVersion_NUnit>3.13.1</PackageVersion_NUnit>
-        <PackageVersion_GitToolsTesting>1.2.0</PackageVersion_GitToolsTesting>
         <PackageVersion_NUnit3TestAdapter>3.17.0</PackageVersion_NUnit3TestAdapter>
         <PackageVersion_NunitXmlTestLogger>3.0.91</PackageVersion_NunitXmlTestLogger>
         <PackageVersion_Shouldly>4.0.3</PackageVersion_Shouldly>

src/GitVersion.Core/Configuration/ConfigFileLocatorFactory.cs

@@ -17,7 +17,7 @@ public ConfigFileLocatorFactory(IFileSystem fileSystem, IOptions<GitVersionOptio
         public IConfigFileLocator Create()
         {
             return string.IsNullOrWhiteSpace(options.Value.ConfigInfo.ConfigFile)
-                ? new DefaultConfigFileLocator(fileSystem) as IConfigFileLocator
+                ? new DefaultConfigFileLocator(fileSystem)
                 : new NamedConfigFileLocator(fileSystem, options);
         }
     }

src/GitVersion.Core/Model/VersionVariables.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Buffers;
 using System.Collections;
 using System.Collections.Generic;
 using System.IO;

src/GitVersion.Core/Model/VersionVariablesJsonNumberConverter.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Buffers;
 using System.Buffers.Text;
-using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using JetBrains.Annotations;

src/GitVersion.Core/Model/VersionVariablesJsonStringConverter.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Buffers;
 using System.Buffers.Text;
-using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using JetBrains.Annotations;
@@ -37,7 +36,5 @@ public override void Write(Utf8JsonWriter writer, [CanBeNull] string value, Json
         }
 
         public override bool HandleNull => true;
-
-        private static bool NotAPaddedNumber(string value) => value != null && (value == "0" || !value.StartsWith("0"));
     }
 }

src/GitVersion.Core/VersionCalculation/IncrementStrategyFinder.cs

@@ -21,12 +21,12 @@ public static class IncrementStrategyFinder
         public const string DefaultPatchPattern = @"\+semver:\s?(fix|patch)";
         public const string DefaultNoBumpPattern = @"\+semver:\s?(none|skip)";
 
-        private static readonly ConcurrentDictionary<string, Regex> CompiledRegexCache = new ConcurrentDictionary<string, Regex>();
+        private static readonly ConcurrentDictionary<string, Regex> CompiledRegexCache = new();
 
-        private static readonly Regex DefaultMajorPatternRegex = new Regex(DefaultMajorPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
-        private static readonly Regex DefaultMinorPatternRegex = new Regex(DefaultMinorPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
-        private static readonly Regex DefaultPatchPatternRegex = new Regex(DefaultPatchPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
-        private static readonly Regex DefaultNoBumpPatternRegex = new Regex(DefaultNoBumpPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
+        private static readonly Regex DefaultMajorPatternRegex = new(DefaultMajorPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
+        private static readonly Regex DefaultMinorPatternRegex = new(DefaultMinorPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
+        private static readonly Regex DefaultPatchPatternRegex = new(DefaultPatchPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
+        private static readonly Regex DefaultNoBumpPatternRegex = new(DefaultNoBumpPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
 
         public static VersionField? DetermineIncrementedField(IGitRepository repository, GitVersionContext context, BaseVersion baseVersion)
         {
@@ -36,7 +36,7 @@ public static class IncrementStrategyFinder
             // use the default branch config increment strategy if there are no commit message overrides
             if (commitMessageIncrement == null)
             {
-                return baseVersion.ShouldIncrement ? defaultIncrement : (VersionField?)null;
+                return baseVersion.ShouldIncrement ? defaultIncrement : null;
             }
 
             // cap the commit message severity to minor for alpha versions