Remove default value for 'formatProvider' in SemanticVersionPreReleaseTag.ToString

chris-codeflow · chris-codeflow · commit 3ffbf8e5dea0 · 2021-10-14T22:12:46.000+01:00
- Align SemanticVersion.ToString implementation of IFormattable.ToString with .NET Standard 2.0 definition.
diff --git a/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs b/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs
@@ -111,7 +111,7 @@ public int CompareTo(SemanticVersionPreReleaseTag? other)
     /// <para>l - Legacy SemVer tag with the tag number padded. [beta1]</para>
     /// <para>lp - Legacy SemVer tag with the tag number padded. [beta0001]. Can specify an integer to control padding (i.e., lp5)</para>
     /// </summary>
-    public string ToString(string format, IFormatProvider formatProvider = null)
+    public string ToString(string format, IFormatProvider formatProvider)
     {
         if (formatProvider != null)
         {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public int CompareTo(SemanticVersionPreReleaseTag? other)`
`111`	`111`	`/// <para>l - Legacy SemVer tag with the tag number padded. [beta1]</para>`
`112`	`112`	`/// <para>lp - Legacy SemVer tag with the tag number padded. [beta0001]. Can specify an integer to control padding (i.e., lp5)</para>`
`113`	`113`	`/// </summary>`
`114`		`- public string ToString(string format, IFormatProvider formatProvider = null)`
	`114`	`+ public string ToString(string format, IFormatProvider formatProvider)`
`115`	`115`	`{`
`116`	`116`	`if (formatProvider != null)`
`117`	`117`	`{`