Add Travis-CI #43
Closed
Add Travis-CI #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 18, 2015 13:44
"# do something here" throws off doctest in Python 2.7, removed a > to make that one not a doctest. Added .travis.yml for Travis-CI. I'm expecting Python 3.x tests to fail.
Contributor
Author
Contributor
Author
|
Just curious, is this useful to the project or not? Is there something that might need to be changed to make this able to be merged? |
|
@GeospatialPython +1 for adding Travis-CI support. It would give everybody contributing PRs peace of mind that they did not break anything. |
restore & fix iterShapeRecords() doctest
Contributor
Author
|
@ARF1 got the iterShapeRecords() example working, thanks! |
ARF1
pushed a commit
to ARF1/pyshp
that referenced
this pull request
Apr 12, 2016
* Incorporates rebased GeospatialPython#43 * Closes GeospatialPython#43 * Add Travis-CI, remove one doctest "... # do something here" throws off doctest in Python 2.7, removed a > to make that one not a doctest. Added .travis.yml for Travis-CI. I'm expecting Python 3.x tests to fail. * on success test return 0, on failure return the number of failed tests * added sys.exit() for return code * convert README.txt from dos to unix format, see if it helps doctest
ARF1
pushed a commit
to ARF1/pyshp
that referenced
this pull request
Apr 12, 2016
* Incorporates rebased GeospatialPython#43 * Closes GeospatialPython#43 * Add Travis-CI, remove one doctest "... # do something here" throws off doctest in Python 2.7, removed a > to make that one not a doctest. Added .travis.yml for Travis-CI. I'm expecting Python 3.x tests to fail. * on success test return 0, on failure return the number of failed tests * added sys.exit() for return code * convert README.txt from dos to unix format, see if it helps doctest
Closed
ARF1
pushed a commit
to ARF1/pyshp
that referenced
this pull request
Apr 12, 2016
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Travis-CI support. You will have to login to https://travis-ci.org/ to enable Travis.
Code was added to shapefile.py to return a status on exit (0 success, anything else is failure). This was needed to work on Travis.
This takes 2 minutes to run and makes sure the the submitted code runs on the doctests.
dos2unix converts newline characters from dos format to unix format. This caused problems for many python versions.
iterShapeRecords() was removed from doctests because it isn't a valid doctest.