Generate zip URIs for Go to definition

Author: GGomez99

internal/ls/converters.go

@@ -178,7 +178,14 @@ func FileNameToDocumentURI(fileName string) lsproto.DocumentUri {
 		parts[i] = extraEscapeReplacer.Replace(url.PathEscape(part))
 	}
 
-	return lsproto.DocumentUri("file://" + volume + strings.Join(parts, "/"))
+	var prefix string
+	if tspath.IsZipPath(fileName) {
+		prefix = "zip:"
+	} else {
+		prefix = "file:"
+	}
+
+	return lsproto.DocumentUri(prefix + "//" + volume + strings.Join(parts, "/"))
 }
 
 func (c *Converters) LineAndCharacterToPosition(script Script, lineAndCharacter lsproto.Position) core.TextPos {

internal/tspath/path.go

@@ -920,3 +920,7 @@ func ForEachAncestorDirectoryPath[T any](directory Path, callback func(directory
 func HasExtension(fileName string) bool {
 	return strings.Contains(GetBaseFileName(fileName), ".")
 }
+
+func IsZipPath(path string) bool {
+	return strings.Contains(path, ".zip/") || strings.HasSuffix(path, ".zip")
+}

internal/vfs/zipvfs/zipvfs.go

@@ -9,6 +9,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/microsoft/typescript-go/internal/tspath"
 	"github.com/microsoft/typescript-go/internal/vfs"
 	"github.com/microsoft/typescript-go/internal/vfs/iovfs"
 )
@@ -131,10 +132,6 @@ func (zipfs *zipFS) WriteFile(path string, data string, writeByteOrderMark bool)
 	return fs.WriteFile(formattedPath, data, writeByteOrderMark)
 }
 
-func isZipPath(path string) bool {
-	return strings.Contains(path, ".zip/") || strings.HasSuffix(path, ".zip")
-}
-
 func splitZipPath(path string) (string, string) {
 	parts := strings.Split(path, ".zip/")
 	if len(parts) < 2 {
@@ -144,7 +141,7 @@ func splitZipPath(path string) (string, string) {
 }
 
 func getMatchingFS(zipfs *zipFS, path string) (vfs.FS, string, string) {
-	if !isZipPath(path) {
+	if !tspath.IsZipPath(path) {
 		return zipfs.fs, path, ""
 	}