review feedback changes

Author: tony-josi-aws

source/FreeRTOS_DHCPv6.c

@@ -325,7 +325,7 @@ void vDHCPv6Process( BaseType_t xReset,
             }
             else
             {
-                FreeRTOS_printf( ( "vDHCPv6Process: malloc failed %u bytes\n", ( unsigned ) sizeof( *pxEndPoint->pxDHCPMessage ) ) );
+                FreeRTOS_printf( ( "vDHCPv6Process: malloc failed %u bytes\n", ( unsigned int ) sizeof( *pxEndPoint->pxDHCPMessage ) ) );
             }
         }
     }

source/FreeRTOS_DNS_Parser.c

@@ -313,8 +313,10 @@
         xSet.usPortNumber = usPort;
         xSet.ppxLastAddress = &( xSet.pxLastAddress );
 
-        uint16_t usType = 0U;
-        uint16_t usClass = 0U;
+        #if ( ipconfigUSE_LLMNR == 1 )
+            uint16_t usType = 0U;
+            uint16_t usClass = 0U;
+        #endif /* ipconfigUSE_LLMNR */
 
         #if ( ipconfigUSE_DNS_CACHE == 1 ) || ( ipconfigDNS_USE_CALLBACKS == 1 )
             xSet.xDoStore = xExpected;
@@ -568,9 +570,13 @@
                                 pxAnswer->ucNameOffset = ( uint8_t ) ( xSet.pcRequestedName - ( char * ) pucNewBuffer );
 
                                 #ifndef _lint
-                                    vSetField16( pxAnswer, LLMNRAnswer_t, usType, xSet.usType );  /* Type A or AAAA: host */
-                                    vSetField16( pxAnswer, LLMNRAnswer_t, usClass, dnsCLASS_IN ); /* 1: Class IN */
-                                    vSetField32( pxAnswer, LLMNRAnswer_t, ulTTL, dnsLLMNR_TTL_VALUE );
+                                    #if ( ipconfigUSE_LLMNR == 1 )
+                                    {
+                                        vSetField16( pxAnswer, LLMNRAnswer_t, usType, xSet.usType );  /* Type A or AAAA: host */
+                                        vSetField16( pxAnswer, LLMNRAnswer_t, usClass, dnsCLASS_IN ); /* 1: Class IN */
+                                        vSetField32( pxAnswer, LLMNRAnswer_t, ulTTL, dnsLLMNR_TTL_VALUE );
+                                    }
+                                    #endif /* ipconfigUSE_LLMNR */
                                 #endif /* lint */
 
                                 usLength = ( int16_t ) ( sizeof( *pxAnswer ) + ( size_t ) ( xSet.pucByte - pucNewBuffer ) );
@@ -628,9 +634,6 @@
             /* The IP-address found will be returned. */
         }
 
-        ( void ) usType;
-        ( void ) usClass;
-
         return ulIPAddress;
     }
 
@@ -1041,14 +1044,10 @@
             uint8_t ucNBNSName[ 17 ];
             uint8_t * pucUDPPayloadBuffer = pucPayload;
             NetworkBufferDescriptor_t * pxNetworkBuffer;
-            size_t uxBytesNeeded = sizeof( UDPPacket_t ) + sizeof( NBNSRequest_t );
             NetworkEndPoint_t xEndPoint;
-            BaseType_t xMustReply = pdFALSE;
 
             /* Not used for now */
             ( void ) uxBufferLength;
-            ( void ) uxBytesNeeded;
-            ( void ) xMustReply;
 
             /* Read the request flags in host endianness. */
             usFlags = usChar2u16( &( pucUDPPayloadBuffer[ offsetof( NBNSRequest_t, usFlags ) ] ) );

source/FreeRTOS_TCP_Utils_IPV6.c

@@ -58,7 +58,7 @@
         uint32_t ulMSS = ipconfigTCP_MSS;
 
         #if ( ipconfigHAS_DEBUG_PRINTF == 1 )
-            char cBuffer[ 40 ];
+            char cIPv6Address [ 40 ];
         #endif
 
         const NetworkEndPoint_t * pxEndPoint = pxSocket->pxEndPoint;
@@ -92,8 +92,8 @@
 
         #if ( ipconfigHAS_DEBUG_PRINTF == 1 )
             {
-                ( void ) FreeRTOS_inet_ntop( FREERTOS_AF_INET6, ( const void * ) pxSocket->u.xTCP.xRemoteIP.xIP_IPv6.ucBytes, cBuffer, sizeof( cBuffer ) );
-                FreeRTOS_debug_printf( ( "prvSocketSetMSS: %u bytes for %s ip port %u\n", ( unsigned ) ulMSS, cBuffer, pxSocket->u.xTCP.usRemotePort ) );
+                ( void ) FreeRTOS_inet_ntop( FREERTOS_AF_INET6, ( const void * ) pxSocket->u.xTCP.xRemoteIP.xIP_IPv6.ucBytes, cIPv6Address , sizeof( cIPv6Address  ) );
+                FreeRTOS_debug_printf( ( "prvSocketSetMSS: %u bytes for %s ip port %u\n", ( unsigned ) ulMSS, cIPv6Address , pxSocket->u.xTCP.usRemotePort ) );
             }
         #endif
 

test/build-combination/Common/main.c

@@ -210,37 +210,7 @@ void vApplicationIdleHook( void )
 
     /* Exit. Just a stub. */
 }
-/*-----------------------------------------------------------*/
-void vAssertCalled( const char * pcFile,
-                    unsigned long ulLine )
-{
-    const uint32_t ulLongSleep = 1000UL;
-    volatile uint32_t ulBlockVariable = 0UL;
-    volatile char * pcFileName = ( volatile char * ) pcFile;
-    volatile uint32_t ulLineNumber = ulLine;
 
-    ( void ) pcFileName;
-    ( void ) ulLineNumber;
-
-    taskDISABLE_INTERRUPTS();
-    {
-        while( 1 )
-        {
-        }
-    }
-    taskENABLE_INTERRUPTS();
-}
-/*-----------------------------------------------------------*/
-
-void vLoggingPrintf( const char * pcFormat,
-                     ... )
-{
-    va_list arg;
-
-    va_start( arg, pcFormat );
-    vprintf( pcFormat, arg );
-    va_end( arg );
-}
 /*-----------------------------------------------------------*/
 
 void getUserCmd( char * pucUserCmd )