Address comments from reviews

Author: ChristosZosi

source/portable/NetworkInterface/xilinx_ultrascale/x_emacpsif_hw.c

@@ -49,13 +49,13 @@ void setup_isr( xemacpsif_s * xemacpsif )
      */
     XEmacPs * xInstancePtr = &( xemacpsif->emacps );
 
-    xInstancePtr->SendHandler = ( XEmacPs_Handler ) emacps_send_handler;
+    xInstancePtr->SendHandler = emacps_send_handler;
     xInstancePtr->SendRef = ( void * ) xemacpsif;
 
-    xInstancePtr->RecvHandler = ( XEmacPs_Handler ) emacps_recv_handler;
+    xInstancePtr->RecvHandler = emacps_recv_handler;
     xInstancePtr->RecvRef = ( void * ) xemacpsif;
 
-    xInstancePtr->ErrorHandler = ( XEmacPs_ErrHandler ) emacps_error_handler;
+    xInstancePtr->ErrorHandler = emacps_error_handler;
     xInstancePtr->ErrorRef = ( void * ) xemacpsif;
 }
 

source/portable/NetworkInterface/xilinx_ultrascale/x_emacpsif_physpeed.c

@@ -245,18 +245,10 @@ void my_sleep( uint32_t uxTicks )
 u32 phymapemac0[ 32 ];
 u32 phymapemac1[ 32 ];
 
-static uint16_t prvAR803x_debug_reg_read( XEmacPs * xemacpsp,
-                                          uint32_t phy_addr,
-                                          u16 reg );
 static uint16_t prvAR803x_debug_reg_write( XEmacPs * xemacpsp,
                                            uint32_t phy_addr,
                                            u16 reg,
                                            u16 value );
-static int prvAR803x_debug_reg_mask( XEmacPs * xemacpsp,
-                                     uint32_t phy_addr,
-                                     u16 reg,
-                                     u16 clear,
-                                     u16 set );
 static void prvSET_AR803x_TX_Timing( XEmacPs * xemacpsp,
                                      uint32_t phy_addr );
 
@@ -832,32 +824,8 @@ static uint32_t get_AR8035_phy_speed( XEmacPs * xemacpsp,
     }
 }
 
-static void ar8035Tick( XEmacPs * xemacpsp,
-                        uint32_t phy_addr )
-{
-    uint16_t value;
-    BaseType_t linkState;
-
-    /*Read basic status register */
-    value = XEmacPs_PhyRead2( xemacpsp, phy_addr, IEEE_STATUS_REG_OFFSET );
-    /*Retrieve current link state */
-    linkState = ( value & IEEE_STAT_LINK_STATUS ) ? TRUE : FALSE;
-
-    /* Just to prevent compiler warnings about unused variable. */
-    ( void ) linkState;
-}
-
 #define AR803X_DEBUG_ADDR    0x1D
 #define AR803X_DEBUG_DATA    0x1E
-static uint16_t prvAR803x_debug_reg_read( XEmacPs * xemacpsp,
-                                          uint32_t phy_addr,
-                                          u16 reg )
-{
-    XEmacPs_PhyWrite( xemacpsp, phy_addr, AR803X_DEBUG_ADDR, reg );
-
-    return XEmacPs_PhyRead2( xemacpsp, phy_addr, AR803X_DEBUG_DATA );
-}
-
 static uint16_t prvAR803x_debug_reg_write( XEmacPs * xemacpsp,
                                            uint32_t phy_addr,
                                            u16 reg,
@@ -868,29 +836,6 @@ static uint16_t prvAR803x_debug_reg_write( XEmacPs * xemacpsp,
     return XEmacPs_PhyWrite( xemacpsp, phy_addr, AR803X_DEBUG_DATA, value );
 }
 
-static int prvAR803x_debug_reg_mask( XEmacPs * xemacpsp,
-                                     uint32_t phy_addr,
-                                     u16 reg,
-                                     u16 clear,
-                                     u16 set )
-{
-    u16 val;
-    int ret;
-
-    ret = prvAR803x_debug_reg_read( xemacpsp, phy_addr, reg );
-
-    if( ret < 0 )
-    {
-        return ret;
-    }
-
-    val = ret & 0xffff;
-    val &= ~clear;
-    val |= set;
-
-    return XEmacPs_PhyWrite( xemacpsp, phy_addr, AR803X_DEBUG_DATA, val );
-}
-
 static uint32_t ar8035CheckStatus( XEmacPs * xemacpsp,
                                    uint32_t phy_addr )
 {