Skip to content

Commit 588c437

Browse files
Update after comments
1 parent 11a14f1 commit 588c437

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

.github/lexicon.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ ahb
1818
amba
1919
analyse
2020
ap
21-
apchr
2221
api
2322
apis
2423
april

FreeRTOS_IP.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3726,41 +3726,41 @@ ipDECL_CAST_CONST_PTR_FUNC_FOR_TYPE( FreeRTOS_Socket_t )
37263726
return ( const SocketSelectMessage_t * ) pvArgument;
37273727
}
37283728
/*-----------------------------------------------------------*/
3729-
#endif /* if ( ipconfigSUPPORT_SELECT_FUNCTION == 1 ) */
3729+
#endif /* ipconfigSUPPORT_SELECT_FUNCTION == 1 */
37303730
/** @} */
37313731

37323732
/**
37333733
* @brief Convert character array (of size 4) to equivalent 32-bit value.
3734-
* @param[in] apChr: The character array.
3734+
* @param[in] pucPtr: The character array.
37353735
* @return 32-bit equivalent value extracted from the character array.
37363736
*
37373737
* @note Going by MISRA rules, these utility functions should not be defined
37383738
* if they are not being used anywhere. But their use depends on the
37393739
* application and hence these functions are defined unconditionally.
37403740
*/
3741-
uint32_t ulChar2u32( const uint8_t * apChr )
3741+
uint32_t ulChar2u32( const uint8_t * pucPtr )
37423742
{
3743-
return ( ( ( uint32_t ) apChr[ 0 ] ) << 24 ) |
3744-
( ( ( uint32_t ) apChr[ 1 ] ) << 16 ) |
3745-
( ( ( uint32_t ) apChr[ 2 ] ) << 8 ) |
3746-
( ( ( uint32_t ) apChr[ 3 ] ) );
3743+
return ( ( ( uint32_t ) pucPtr[ 0 ] ) << 24 ) |
3744+
( ( ( uint32_t ) pucPtr[ 1 ] ) << 16 ) |
3745+
( ( ( uint32_t ) pucPtr[ 2 ] ) << 8 ) |
3746+
( ( ( uint32_t ) pucPtr[ 3 ] ) );
37473747
}
37483748
/*-----------------------------------------------------------*/
37493749

37503750
/**
37513751
* @brief Convert character array (of size 2) to equivalent 16-bit value.
3752-
* @param[in] apChr: The character array.
3752+
* @param[in] pucPtr: The character array.
37533753
* @return 16-bit equivalent value extracted from the character array.
37543754
*
37553755
* @note Going by MISRA rules, these utility functions should not be defined
37563756
* if they are not being used anywhere. But their use depends on the
37573757
* application and hence these functions are defined unconditionally.
37583758
*/
3759-
uint16_t usChar2u16( const uint8_t * apChr )
3759+
uint16_t usChar2u16( const uint8_t * pucPtr )
37603760
{
37613761
return ( uint16_t )
3762-
( ( ( ( uint32_t ) apChr[ 0 ] ) << 8 ) |
3763-
( ( ( uint32_t ) apChr[ 1 ] ) ) );
3762+
( ( ( ( uint32_t ) pucPtr[ 0 ] ) << 8 ) |
3763+
( ( ( uint32_t ) pucPtr[ 1 ] ) ) );
37643764
}
37653765
/*-----------------------------------------------------------*/
37663766

include/FreeRTOS_IP_Private.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -833,9 +833,9 @@
833833
* if they are not being used anywhere. But their use depends on the
834834
* application and hence these functions are defined unconditionally.
835835
*/
836-
extern uint32_t ulChar2u32( const uint8_t * apChr );
836+
extern uint32_t ulChar2u32( const uint8_t * pucPtr );
837837

838-
extern uint16_t usChar2u16( const uint8_t * apChr );
838+
extern uint16_t usChar2u16( const uint8_t * pucPtr );
839839

840840
/* Check a single socket for retransmissions and timeouts */
841841
BaseType_t xTCPSocketCheck( FreeRTOS_Socket_t * pxSocket );

0 commit comments

Comments
 (0)