Address PR comments

Author: kstribrnAmzn

source/FreeRTOS_DNS.c

@@ -735,8 +735,8 @@
         #if defined( _lint ) || defined( __COVERITY__ )
             ( void ) pxTail;
         #else
-            vSetField16( pxTail, DNSTail_t, usType, dnsTYPE_A_HOST )
-            vSetField16( pxTail, DNSTail_t, usClass, dnsCLASS_IN )
+            vSetField16( pxTail, DNSTail_t, usType, dnsTYPE_A_HOST );
+            vSetField16( pxTail, DNSTail_t, usClass, dnsCLASS_IN );
         #endif
 
         /* Return the total size of the generated message, which is the space from

source/FreeRTOS_IP_Utils.c

@@ -97,22 +97,22 @@
 /**
  * Used in checksum calculation.
  */
-typedef union xUnion32_t
+typedef union xUnion32
 {
     uint32_t u32;      /**< The 32-bit member of the union. */
     uint16_t u16[ 2 ]; /**< The array of 2 16-bit members of the union. */
     uint8_t u8[ 4 ];   /**< The array of 4 8-bit members of the union. */
-} xUnion32;
+} xUnion32_t;
 
 /**
  * Used in checksum calculation.
  */
-typedef union xUnionPtr_t
+typedef union xUnionPtr
 {
     const uint32_t * u32ptr; /**< The pointer member to a 32-bit variable. */
     const uint16_t * u16ptr; /**< The pointer member to a 16-bit variable. */
     const uint8_t * u8ptr;   /**< The pointer member to an 8-bit variable. */
-} xUnionPtr;
+} xUnionPtr_t;
 
 /*
  * Returns the network buffer descriptor that owns a given packet buffer.
@@ -830,10 +830,10 @@ uint16_t usGenerateChecksum( uint16_t usSum,
 {
 /* MISRA/PC-lint doesn't like the use of unions. Here, they are a great
  * aid though to optimise the calculations. */
-    xUnion32 xSum2;
-    xUnion32 xSum;
-    xUnion32 xTerm;
-    xUnionPtr xSource;
+    xUnion32_t xSum2;
+    xUnion32_t xSum;
+    xUnion32_t xTerm;
+    xUnionPtr_t xSource;
     uintptr_t uxAlignBits;
     uint32_t ulCarry = 0U;
     uint16_t usTemp;

source/FreeRTOS_TCP_IP.c

@@ -662,7 +662,6 @@
         usRemotePort = FreeRTOS_htons( pxProtocolHeaders->xTCPHeader.usSourcePort );
         ulSequenceNumber = FreeRTOS_ntohl( pxProtocolHeaders->xTCPHeader.ulSequenceNumber );
         ulAckNumber = FreeRTOS_ntohl( pxProtocolHeaders->xTCPHeader.ulAckNr );
-        xResult = pdPASS;
 
         /* Check for a minimum packet size. */
         if( pxNetworkBuffer->xDataLength < ( ipSIZE_OF_ETH_HEADER + xIPHeaderSize( pxNetworkBuffer ) + ipSIZE_OF_TCP_HEADER ) )

source/FreeRTOS_UDP_IP.c

@@ -310,7 +310,7 @@ BaseType_t xProcessReceivedUDPPacket( NetworkBufferDescriptor_t * pxNetworkBuffe
 {
     BaseType_t xReturn = pdPASS;
     FreeRTOS_Socket_t * pxSocket;
-    UDPPacket_t * pxUDPPacket;
+    const UDPPacket_t * pxUDPPacket;
 
     configASSERT( pxNetworkBuffer != NULL );
     configASSERT( pxNetworkBuffer->pucEthernetBuffer != NULL );

source/include/FreeRTOS_IP_Private.h

@@ -400,10 +400,10 @@ extern const BaseType_t xBufferAllocFixedSize;
 #define SOCKET_EVENT_BIT_COUNT         8
 
 #define vSetField16( pxBase, xType, xField, usValue )                                                        \
-    {                                                                                                        \
+    do {                                                                                                     \
         ( ( uint8_t * ) ( pxBase ) )[ offsetof( xType, xField ) + 0 ] = ( uint8_t ) ( ( usValue ) >> 8 );    \
         ( ( uint8_t * ) ( pxBase ) )[ offsetof( xType, xField ) + 1 ] = ( uint8_t ) ( ( usValue ) & 0xffU ); \
-    }
+    } while( ipFALSE_BOOL )
 
 #define vSetField32( pxBase, xType, xField, ulValue )                                                                  \
     {                                                                                                                  \