Fix MISRA_C_2012 rule 8.2 violation #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 6 6
Lines 3179 3179
Branches 885 885
=======================================
Hits 2981 2981
Misses 91 91
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
moninom1
approved these changes
Oct 31, 2023
chinglee-iot
reviewed
Nov 6, 2023
Member
chinglee-iot
left a comment
chinglee-iot
left a comment
There was a problem hiding this comment.
Can we also elaborate what could be the problem if parameter name is not specified in the prototype?
Suggest we still following the naming convention for the parameters.
aggarg
approved these changes
Dec 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MISRA_C_2012 rule 8.2 violation
Description
Misra Rule 8.2
MISRA violation
The parameters in any function prototype should be named. The parameter names can provide useful information regarding the function interface and a mismatch between a declaration and definition might be indicative of a programming error.
The function prototype:
Fix
Test Steps
N/A.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.