Skip to content

Conversation

@chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Aug 31, 2023

Update task running state macro and types.

Description

  • Remove type TaskRunning_t use BaseType_t for TaskRunning_t directly.
  • Rename taskTASK_YIELDING to taskSCHEDULED_TO_YIELD.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Address #750 comment in line 263, 266, 268.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from a team as a code owner August 31, 2023 13:53
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (288d143) 94.35% compared to head (0e03f1a) 94.35%.
Report is 1 commits behind head on main.

❗ Current head 0e03f1a differs from pull request most recent head f6f78a2. Consider uploading reports for the commit f6f78a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files           6        6           
  Lines        2446     2446           
  Branches      598      598           
=======================================
  Hits         2308     2308           
  Misses         85       85           
  Partials       53       53           
Flag Coverage Δ
unittests 94.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tasks.c 94.83% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinglee-iot chinglee-iot changed the title Remove TaskRunning_t type Update task running state macro and type Aug 31, 2023
ActoryOu
ActoryOu previously approved these changes Sep 1, 2023
ActoryOu
ActoryOu previously approved these changes Sep 4, 2023
aggarg
aggarg previously approved these changes Sep 6, 2023
@chinglee-iot chinglee-iot dismissed stale reviews from aggarg and ActoryOu via 0e03f1a September 6, 2023 09:28
@chinglee-iot chinglee-iot merged commit c93d386 into FreeRTOS:main Sep 6, 2023
@chinglee-iot chinglee-iot deleted the remove-type-taskrunning branch September 6, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants