Add band configurations to adapt different BG96 modem version #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add CELLULAR_BG96_ENABLE_BAND_CONFIGURATION and CELLULAR_BG96_BAND_CONFIGURATION to adapt different BG96 modem version
|
Hello, I just tested the PR. I think it could be nice to have same for all the configurations parameters. So users could configure their BG96 with their own configuration file without having to modify the cellular_bg96.h Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Different BG96 cellular modem version support different band settings. This PR add two configurations to adapt the these various.
CELLULAR_BG96_ENABLE_BAND_CONFIGURATIONandCELLULAR_BG96_BAND_CONFIGURATIONto adapt different BG96 modem versionTest Steps
N/A
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.