Skip to content

Commit 498c064

Browse files
SkptakSkptak
authored
Update PR Check Actions (#106)
* Use most recently released versions of various github actions. * Update PR checks to account for changes in downstream repos.
1 parent d435b75 commit 498c064

File tree

8 files changed

+116
-112
lines changed

8 files changed

+116
-112
lines changed

‎.github/workflows/executableMonitorTests.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
os: [ubuntu-latest, windows-latest]
2424
runs-on: ${{ matrix.os }}
2525
steps:
26-
- uses: actions/checkout@v3
26+
- uses: actions/checkout@v4.1.1
2727

2828
- env:
2929
stepName: Install Windows Build tools
@@ -185,7 +185,7 @@ jobs:
185185

186186
runs-on: ${{ matrix.os }}
187187
steps:
188-
- uses: actions/checkout@v3
188+
- uses: actions/checkout@v4.1.1
189189
- env:
190190
stepName: Install Windows Build tools
191191
name: ${{ env.stepName }}

‎.github/workflows/formattingTests.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
uncrustify-formatting-success-cases:
1919
runs-on: ubuntu-20.04
2020
steps:
21-
- uses: actions/checkout@v3
21+
- uses: actions/checkout@v4.1.1
2222

2323
- env:
2424
stepName: "Functional | Success | Exclude Files and Dirs"
@@ -61,7 +61,7 @@ jobs:
6161
uncrustify-formatting-error-cases:
6262
runs-on: ubuntu-20.04
6363
steps:
64-
- uses: actions/checkout@v3
64+
- uses: actions/checkout@v4.1.1
6565
- env:
6666
stepName: "Functional | Failure | Whitespace, CRLF, and Format Failure"
6767
name: ${{ env.stepName }}
@@ -297,7 +297,7 @@ jobs:
297297
clang-formatting-success-cases:
298298
runs-on: ubuntu-latest
299299
steps:
300-
- uses: actions/checkout@v3
300+
- uses: actions/checkout@v4.1.1
301301

302302
- env:
303303
stepName: "Functional | Success | Exclude Files and Dirs"
@@ -340,7 +340,7 @@ jobs:
340340
clang-formatting-error-cases:
341341
runs-on: ubuntu-latest
342342
steps:
343-
- uses: actions/checkout@v3
343+
- uses: actions/checkout@v4.1.1
344344
- env:
345345
stepName: "Functional | Failure | Whitespace, CRLF, and Format Failure"
346346
name: ${{ env.stepName }}

‎.github/workflows/pr_checks.yml‎

Lines changed: 84 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ jobs:
5353
run-link-verifier: true,
5454
run-complexity: true,
5555
run-doxygen: true,
56-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_UNIT_TESTS=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
56+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
5757
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*3rdparty\*"',
58-
line-coverage: 100,
5958
},
6059
{
6160
repository: coreHTTP,
@@ -66,7 +65,6 @@ jobs:
6665
run-doxygen: true,
6766
build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
6867
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*3rdparty\*"',
69-
line-coverage: 100,
7068
},
7169
{
7270
repository: coreJSON,
@@ -77,7 +75,6 @@ jobs:
7775
run-doxygen: true,
7876
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
7977
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*source\*"',
80-
line-coverage: 100,
8178
},
8279
{
8380
repository: coreMQTT,
@@ -88,7 +85,6 @@ jobs:
8885
run-doxygen: true,
8986
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG -DLIBRARY_LOG_LEVEL=LOG_DEBUG',
9087
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
91-
line-coverage: 100,
9288
},
9389
{
9490
repository: corePKCS11,
@@ -97,9 +93,9 @@ jobs:
9793
run-link-verifier: true,
9894
run-complexity: true,
9995
run-doxygen: true,
100-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DUNIT_TESTS=1 -DSYSTEM_TESTS=0 -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
96+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DSYSTEM_TESTS=0 -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
10197
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
102-
line-coverage: 95,
98+
branch-coverage: 90,
10399
},
104100
{
105101
repository: coreSNTP,
@@ -108,9 +104,8 @@ jobs:
108104
run-link-verifier: true,
109105
run-complexity: true,
110106
run-doxygen: true,
111-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_UNIT_TESTS=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG -Wno-error=pedantic -Wno-variadic-macros -DLOGGING_LEVEL_DEBUG=1',
107+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG -Wno-error=pedantic -Wno-variadic-macros -DLOGGING_LEVEL_DEBUG=1',
112108
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
113-
line-coverage: 100,
114109
},
115110
{
116111
repository: FreeRTOS-Cellular-Interface,
@@ -121,7 +116,6 @@ jobs:
121116
run-doxygen: true,
122117
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
123118
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
124-
line-coverage: 99,
125119
},
126120
{
127121
repository: Device-Defender-for-AWS-IoT-embedded-sdk,
@@ -132,73 +126,72 @@ jobs:
132126
run-doxygen: true,
133127
build-flags: -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
134128
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
135-
line-coverage: 100,
136129
},
137-
{
138-
repository: Device-Shadow-for-AWS-IoT-embedded-sdk,
139-
org: AWS,
140-
branch: main,
141-
run-link-verifier: true,
142-
run-complexity: true,
143-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
144-
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
145-
line-coverage: 100,
146-
},
147-
{
148-
repository: Fleet-Provisioning-for-AWS-IoT-embedded-sdk,
149-
org: AWS,
150-
branch: main,
151-
run-link-verifier: true,
152-
run-complexity: true,
153-
run-doxygen: true,
154-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
155-
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
156-
line-coverage: 100,
157-
},
158-
{
159-
repository: Jobs-for-AWS-IoT-embedded-sdk,
160-
org: AWS,
161-
branch: main,
162-
run-link-verifier: true,
163-
run-complexity: false,
164-
run-doxygen: true,
165-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
166-
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*source\*"',
167-
line-coverage: 100,
168-
169-
},
170-
{
171-
repository: ota-for-AWS-IoT-embedded-sdk,
172-
org: AWS,
173-
branch: main,
174-
run-link-verifier: true,
175-
run-complexity: true,
176-
run-doxygen: true,
177-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
178-
line-coverage: 95,
179-
},
180-
{
181-
repository: SigV4-for-AWS-IoT-embedded-sdk,
182-
org: AWS,
183-
branch: main,
184-
run-complexity: true,
185-
run-doxygen: true,
186-
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_UNIT_TESTS=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG -DLOGGING_LEVEL_DEBUG=1',
187-
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
188-
line-coverage: 100,
189-
},
130+
{
131+
repository: Device-Shadow-for-AWS-IoT-embedded-sdk,
132+
org: AWS,
133+
branch: main,
134+
run-link-verifier: true,
135+
run-complexity: true,
136+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
137+
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
138+
},
139+
{
140+
repository: Fleet-Provisioning-for-AWS-IoT-embedded-sdk,
141+
org: AWS,
142+
branch: main,
143+
run-link-verifier: true,
144+
run-complexity: true,
145+
run-doxygen: true,
146+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
147+
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
148+
},
149+
{
150+
repository: Jobs-for-AWS-IoT-embedded-sdk,
151+
org: AWS,
152+
branch: main,
153+
run-link-verifier: true,
154+
run-complexity: false,
155+
run-doxygen: true,
156+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
157+
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*source\*"',
158+
},
159+
{
160+
repository: ota-for-AWS-IoT-embedded-sdk,
161+
org: AWS,
162+
branch: main,
163+
run-link-verifier: true,
164+
run-complexity: true,
165+
run-doxygen: true,
166+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
167+
},
168+
{
169+
repository: SigV4-for-AWS-IoT-embedded-sdk,
170+
org: AWS,
171+
branch: main,
172+
run-complexity: true,
173+
run-doxygen: true,
174+
build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG -DLOGGING_LEVEL_DEBUG=1',
175+
coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
176+
},
190177
]
191178
steps:
192-
- uses: actions/checkout@v3
193-
- uses: actions/setup-python@v3
179+
- uses: actions/checkout@v4.1.1
180+
- uses: actions/setup-python@v5.1.0
194181

195-
- name: Install Common Tools
182+
- env:
183+
stepName: Install Common Tools
196184
shell: bash
197185
run: |
186+
# ${{ env.stepName }}
187+
echo -e "::group::${{ env.bashInfo }} ${{ env.stepName }} ${{ env.bashEnd }}"
188+
sudo apt-get -y update
198189
sudo apt-get install -y lcov sed build-essential cmake
190+
echo -e "::endgroup::"
191+
echo -e "${{ env.bashPass }} ${{ env.stepName }} ${{ env.bashEnd }}"
199192
200193
- name: "Clone: ${{ matrix.inputs.repository }}"
201-
uses: actions/checkout@v3
194+
uses: actions/checkout@v4.1.1
202195
with:
203196
repository: ${{ matrix.inputs.org }}/${{ matrix.inputs.repository }}
204197
ref: ${{ matrix.inputs.branch }}
@@ -241,7 +234,7 @@ jobs:
241234

242235
- name: "Recursive Clone: ${{ matrix.inputs.repository }}"
243236
if: success() || failure()
244-
uses: actions/checkout@v3
237+
uses: actions/checkout@v4.1.1
245238
with:
246239
repository: ${{ matrix.inputs.org }}/${{ matrix.inputs.repository }}
247240
ref: ${{ matrix.inputs.branch }}
@@ -256,17 +249,21 @@ jobs:
256249
working-directory: repo/${{ matrix.inputs.repository }}_Recursive
257250
run: git submodule update --checkout --init --recursive
258251

259-
- name: Build ${{matrix.inputs.repository}}
252+
- env:
253+
stepName: Build ${{matrix.inputs.repository}}
260254
if: matrix.inputs.run-complexity && ( success() || failure() )
261255
shell: bash
262256
working-directory: repo/${{matrix.inputs.repository}}_Recursive
263257
run: |
264-
echo -e "::group:: Install lcov"
265-
sudo apt-get install -y lcov
266-
echo -e "::endgroup::"
267-
cmake -S ./test -B build/ ${{ matrix.inputs.build-flags }}
258+
# ${{ env.stepName }}
259+
echo -e "::group::${{ env.bashInfo }} ${{ env.stepName }} ${{ env.bashEnd }}"
260+
261+
cmake -S ./test -B build/ ${{ matrix.inputs.build-flags }} -DUNITTEST=ON
268262
make -C build/ all
269263
264+
echo -e "::endgroup::"
265+
echo -e "${{ env.bashPass }} ${{ env.stepName }} ${{ env.bashEnd }}"
266+
270267
- name: Test
271268
if: matrix.inputs.run-complexity && ( success() || failure() )
272269
shell: bash
@@ -289,27 +286,34 @@ jobs:
289286
output: size_table_new.html
290287
check_against: docs/doxygen/include/size_table.md
291288

292-
- name: Run Coverage ${{matrix.inputs.repository}}
289+
- env:
290+
stepName: Coverage ${{matrix.inputs.repository}}
293291
if: matrix.inputs.run-complexity && ( success() || failure() )
294292
shell: bash
295293
working-directory: repo/${{matrix.inputs.repository}}_Recursive
296294
run: |
295+
# ${{ env.stepName }}
296+
echo -e "::group::${{ env.bashInfo }} Build ${{matrix.inputs.repository}} ${{ env.bashEnd }}"
297297
make -C build/ coverage
298+
echo -e "::endgroup::"
299+
echo -e "::group::${{ env.bashInfo }} ${{ env.stepName }} ${{ env.bashEnd }}"
300+
298301
if [[ "${{ matrix.inputs.coverage-skips }}" != "" ]]; then
299302
declare -a EXCLUDE=( ${{ matrix.inputs.coverage-skips }} )
300303
echo ${EXCLUDE[@]} | xargs lcov --rc lcov_branch_coverage=1 -r build/coverage.info -o build/coverage.info
301304
else
302305
lcov --rc lcov_branch_coverage=1 -r build/coverage.info -o build/coverage.info
303306
fi
307+
echo -e "::endgroup::"
308+
304309
lcov --rc lcov_branch_coverage=1 --list build/coverage.info
305310
306311
- name: Test coverage cop action ${{matrix.inputs.repository}}
307312
if: matrix.inputs.run-complexity && ( success() || failure() )
308313
uses: ./coverage-cop
309314
with:
310315
coverage-file: repo/${{matrix.inputs.repository}}_Recursive/build/coverage.info
311-
branch-coverage-min: 70
312-
line-coverage-min: ${{ matrix.inputs.line-coverage }}
316+
branch-coverage-min: ${{ matrix.inputs.branch_coverage }}
313317

314318
PR-uncrustify-checks:
315319
runs-on: ubuntu-20.04
@@ -404,11 +408,11 @@ jobs:
404408
]
405409

406410
steps:
407-
- uses: actions/checkout@v3
408-
- uses: actions/setup-python@v3
411+
- uses: actions/checkout@v4.1.1
412+
- uses: actions/setup-python@v5.1.0
409413

410414
- name: "Clone: ${{ matrix.inputs.repository }}"
411-
uses: actions/checkout@v3
415+
uses: actions/checkout@v4.1.1
412416
with:
413417
repository: ${{ matrix.inputs.org }}/${{ matrix.inputs.repository }}
414418
ref: ${{ matrix.inputs.branch }}

0 commit comments

Comments
 (0)