From 625f3e904df7ae55d222cc05e957b557aa5ab0ba Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Sat, 13 Jan 2018 03:18:15 +0300
Subject: [PATCH 1/2] quote xml attributes

---
 OsmData.py | 58 +++++++++++++++++++++++++++++-------------------------
 1 file changed, 31 insertions(+), 27 deletions(-)

diff --git a/OsmData.py b/OsmData.py
index 66c6ada..e60b4d0 100644
--- a/OsmData.py
+++ b/OsmData.py
@@ -26,8 +26,12 @@
 #       MA 02110-1301, USA.
 
 import xml.sax
+import xml.sax.saxutils
 import copy
 
+def quoteattr(attr):
+    return xml.sax.saxutils.quoteattr(str(attr))
+
 LON = 1
 LAT = 2
 REF = 3
@@ -138,7 +142,7 @@ def write(self, targetStream):
             targetStream.write("<!--" + text + "-->\n")
         targetStream.write("</osm>")
     def xmlnode(self, node):
-        string = ("<node id='" + str(node[0]) + "' ");
+        string = ("<node id=" + quoteattr(node[0]) + " ");
         tags = {}
         for attr in node[1].items():
             if attr[0] == ACTION:
@@ -147,29 +151,29 @@ def xmlnode(self, node):
                 elif attr[1] == DELETE:
                     string += ("action='delete' ");
             elif attr[0] == VERSION:
-                string += ("version='" + str(attr[1]) + "' ")
+                string += ("version=" + quoteattr(attr[1]) + " ")
             elif attr[0] == CHANGESET:
-                string += ("changeset='" + str(attr[1]) + "' ")
+                string += ("changeset=" + quoteattr(attr[1]) + " ")
             elif attr[0] == UID:
-                string += ("uid='" + str(attr[1]) + "' ")
+                string += ("uid=" + quoteattr(attr[1]) + " ")
             elif attr[0] == LAT:
-                string += ("lat='" + str(attr[1]) + "' ")
+                string += ("lat=" + quoteattr(attr[1]) + " ")
             elif attr[0] == LON:
-                string += ("lon='" + str(attr[1]) + "' ")
+                string += ("lon=" + quoteattr(attr[1]) + " ")
             elif attr[0] == USER:
-                string += ("user='" + str(attr[1]) + "' ")
+                string += ("user=" + quoteattr(attr[1]) + " ")
             elif attr[0] == "timestamp" or attr[0] == "visible":
-                string += (attr[0] + "='" + str(attr[1]) + "' ")
+                string += (attr[0] + "=" + quoteattr(attr[1]) + " ")
         if len(node[1][TAG]) > 0:
             string += (">\n")
             for tag in node[1][TAG].items():
-                string += ("<tag k='" + str(tag[0]) + "' v='" + str(tag[1]) + "' />\n")
+                string += ("<tag k=" + quoteattr(tag[0]) + " v=" + quoteattr(tag[1]) + " />\n")
             string += ("</node>\n")
         else:
             string += ("/>\n")
         return string
     def xmlway(self, way):
-        string = ("<way id='" + str(way[0]) + "' ");
+        string = ("<way id=" + quoteattr(way[0]) + " ");
         tags = {}
         for attr in way[1].items():
             if attr[0] == ACTION:
@@ -178,24 +182,24 @@ def xmlway(self, way):
                 elif attr[1] == DELETE:
                     string += ("action='delete' ");
             elif attr[0] == VERSION:
-                string += ("version='" + str(attr[1]) + "' ")
+                string += ("version=" + quoteattr(attr[1]) + " ")
             elif attr[0] == CHANGESET:
-                string += ("changeset='" + str(attr[1]) + "' ")
+                string += ("changeset=" + quoteattr(attr[1]) + " ")
             elif attr[0] == UID:
-                string += ("uid='" + str(attr[1]) + "' ")
+                string += ("uid=" + quoteattr(attr[1]) + " ")
             elif attr[0] == USER:
-                string += ("user='" + str(attr[1]) + "' ")
+                string += ("user=" + quoteattr(attr[1]) + " ")
             elif attr[0] == "timestamp" or attr[0] == "visible":
-                string += (attr[0] + "='" + str(attr[1]) + "' ")
+                string += (attr[0] + "=" + quoteattr(attr[1]) + " ")
         string += (">\n")
         for ref in way[1][REF]:
-            string += ("<nd ref='" + str(ref) + "' />\n")
+            string += ("<nd ref=" + quoteattr(ref) + " />\n")
         for tag in way[1][TAG].items():
-            string += ("<tag k='" + str(tag[0]) + "' v='" + str(tag[1]) + "' />\n")
+            string += ("<tag k=" + quoteattr(tag[0]) + " v=" + quoteattr(tag[1]) + " />\n")
         string += ("</way>\n")
         return string
     def xmlrelation(self, relation):
-        string = ("<relation id='" + str(relation[0]) + "' ");
+        string = ("<relation id=" + quoteattr(relation[0]) + " ");
         tags = {}
         for attr in relation[1].items():
             if attr[0] == ACTION:
@@ -204,24 +208,24 @@ def xmlrelation(self, relation):
                 elif attr[1] == DELETE:
                     string += ("action='delete' ");
             elif attr[0] == VERSION:
-                string += ("version='" + str(attr[1]) + "' ")
+                string += ("version=" + quoteattr(attr[1]) + " ")
             elif attr[0] == CHANGESET:
-                string += ("changeset='" + str(attr[1]) + "' ")
+                string += ("changeset=" + quoteattr(attr[1]) + " ")
             elif attr[0] == UID:
-                string += ("uid='" + str(attr[1]) + "' ")
+                string += ("uid=" + quoteattr(attr[1]) + " ")
             elif attr[0] == USER:
-                string += ("user='" + str(attr[1]) + "' ")
+                string += ("user=" + quoteattr(attr[1]) + " ")
             elif attr[0] == "timestamp" or attr[0] == "visible":
-                string += (attr[0] + "='" + str(attr[1]) + "' ")
+                string += (attr[0] + "=" + quoteattr(attr[1]) + " ")
         string += (">\n")
         for ref in relation[1][REF][NODES]:
-            string += ("<member type='node' ref='" + str(ref[0]) + "' role='" + str(ref[1]) + "' />\n")
+            string += ("<member type='node' ref=" + quoteattr(ref[0]) + " role=" + quoteattr(ref[1]) + " />\n")
         for ref in relation[1][REF][WAYS]:
-            string += ("<member type='way' ref='" + str(ref[0]) + "' role='" + str(ref[1]) + "' />\n")
+            string += ("<member type='way' ref=" + quoteattr(ref[0]) + " role=" + quoteattr(ref[1]) + " />\n")
         for ref in relation[1][REF][RELATIONS]:
-            string += ("<member type='relation' ref='" + str(ref[0]) + "' role='" + str(ref[1]) + "' />\n")
+            string += ("<member type='relation' ref=" + quoteattr(ref[0]) + " role=" + quoteattr(ref[1]) + " />\n")
         for tag in relation[1][TAG].items():
-            string += ("<tag k='" + str(tag[0]) + "' v='" + str(tag[1]) + "' />\n")
+            string += ("<tag k=" + quoteattr(tag[0]) + " v=" + quoteattr(tag[1]) + " />\n")
         string += ("</relation>\n")
         return string
     def startElement(self, tag, attributes):

From 79f8b1266486ad6327dcd630b1de33b0bb875a57 Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Sat, 13 Jan 2018 03:30:36 +0300
Subject: [PATCH 2/2] removed some unused variables

---
 OsmData.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/OsmData.py b/OsmData.py
index e60b4d0..c8feeb8 100644
--- a/OsmData.py
+++ b/OsmData.py
@@ -143,7 +143,6 @@ def write(self, targetStream):
         targetStream.write("</osm>")
     def xmlnode(self, node):
         string = ("<node id=" + quoteattr(node[0]) + " ");
-        tags = {}
         for attr in node[1].items():
             if attr[0] == ACTION:
                 if attr[1] == MODIFY:
@@ -174,7 +173,6 @@ def xmlnode(self, node):
         return string
     def xmlway(self, way):
         string = ("<way id=" + quoteattr(way[0]) + " ");
-        tags = {}
         for attr in way[1].items():
             if attr[0] == ACTION:
                 if attr[1] == MODIFY:
@@ -200,7 +198,6 @@ def xmlway(self, way):
         return string
     def xmlrelation(self, relation):
         string = ("<relation id=" + quoteattr(relation[0]) + " ");
-        tags = {}
         for attr in relation[1].items():
             if attr[0] == ACTION:
                 if attr[1] == MODIFY: