Explorer plugin: Support AutoCompleteText Field #863
Conversation
Fix misaligned suggestion text
Garulf
added
enhancement
Co-authored-by: Jeremy Wu <[email protected]>
Co-authored-by: Jeremy Wu <[email protected]>
|
Need to support a custom action keyword and should be good to go. |
|
what do you mean? in this pr? |
Yeah, adding as we speak... If the user has a custom keyword we need to append it to autocomplete |
|
oh right, yes. |
|
Moved some stuff around so we don't repeat too much logic... Come to think of it... should Enter be changed to open the directories? |
|
no, enter goes into the directory, i am actually wanting to change Everything plugin's enter functionality. |
| Keyword = Settings.SearchActionKeywordEnabled ? Settings.SearchActionKeyword : Settings.PathSearchActionKeyword; | ||
| Keyword = Keyword.ToString() == Query.GlobalPluginWildcardSign ? string.Empty : Keyword + " "; |
There was a problem hiding this comment.
i see why you did it this way, but because the action keyword could change during the runtime of the app, this means Keyword is only set once during Init and with a new string value. We need to get this dynamically because could change anytime.
There was a problem hiding this comment.
i am working on tweaking this, will push up when done.
There was a problem hiding this comment.
In my testing it worked even when hotkey changed.
Edit: Never mind you're right.
|
f741420 is working thanks! |
3 participants
Adds Auto Complete support to the file explorer plugin