Adjust JsonRPCPlugin.cs Exception Handling #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjw24
reviewed
Aug 7, 2021
Comment on lines
236
to
238
| // ReSharper disable once AccessToDisposedClosure | ||
| if (!disposed && !process.HasExited) | ||
| // ReSharper disable once AccessToDisposedClosure |
Member
There was a problem hiding this comment.
i remember i deleted these two before, how come they are readded?
Member
Author
There was a problem hiding this comment.
Oh I add it to suppress the warning. Sorry, good to remove them
Member
There was a problem hiding this comment.
Oh ok, sorry I don't use resharper so didn't know what they r for, if required please add them back in.
Member
Author
There was a problem hiding this comment.
Oh ok, sorry I don't use resharper so didn't know what they r for, if required please add them back in.
No just the yellow wavy line a bit annoying.
jjw24
reviewed
Aug 7, 2021
jjw24
reviewed
Aug 7, 2021
jjw24
approved these changes
Aug 7, 2021
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#632 discussion