Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented May 30, 2024

Given that binary storage is not compatible whenever we modify the cache (or sometimes not version compatible). It becomes annoying for people using the debug tool when switching back and forth from the normal release because flow will just stop when this happens.

This pr suppress the exception of a failed deserialization, like the behavior of jsonstorage, because in most time a failed deserialization is not a bug but rather a change.

@onesounds onesounds merged commit 6920f4d into dev May 30, 2024
@onesounds onesounds deleted the suppress-image-cache-exception branch May 30, 2024 20:10
@jjw24
Copy link
Member

jjw24 commented Jul 15, 2024

@taooceros Please add it as a debug line if still required for devs to know the error, otherwise just remove the line. Please don't just comment it out.

@jjw24 jjw24 added the bug Something isn't working label Jul 15, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone Jul 15, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent change in the Flow.Launcher.Infrastructure/Storage module involves commenting out a logging call related to a deserialize error in the BinaryStorage.cs file. This modification impacts how errors are logged during deserialization, potentially reducing the verbosity of log outputs in error scenarios.

Changes

File Path Change Summary
Flow.Launcher.Infrastructure/Storage Commented out a logging call related to a deserialize error in BinaryStorage.cs.

Poem

In bytes and lines, a quiet change,
Logs of errors now rearrange.
Whispers in the silent code,
Deserialization's lighter load.
With each commit, we redefine,
The artful dance of code—divine. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants