-
-
Notifications
You must be signed in to change notification settings - Fork 455
Suppress Binary Storage Exception #2746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@taooceros Please add it as a debug line if still required for devs to know the error, otherwise just remove the line. Please don't just comment it out. |
|
Caution Review failedThe pull request is closed. WalkthroughWalkthroughThe recent change in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Given that binary storage is not compatible whenever we modify the cache (or sometimes not version compatible). It becomes annoying for people using the debug tool when switching back and forth from the normal release because flow will just stop when this happens.
This pr suppress the exception of a failed deserialization, like the behavior of jsonstorage, because in most time a failed deserialization is not a bug but rather a change.