Handle duplicate hotkeys in HotkeyControlDialog #2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in HotkeyControlDialog, and implement the ability to overwrite them
# Conflicts: # Flow.Launcher/SettingWindow.xaml
Yusyuriv
changed the title
Contributor
|
Functionally perfect. If taooceros checks the code and there's nothing wrong, let's merge. Thank you for your hard work |
onesounds
approved these changes
Apr 26, 2024
taooceros
reviewed
Apr 27, 2024
| /// An action that, when called, will unregister this hotkey. If it's <c>null</c>, it's assumed that this hotkey | ||
| /// can't be unregistered, and the "Overwrite" option will not appear in the hotkey dialog. | ||
| /// </param> | ||
| public RegisteredHotkeyData( |
Member
There was a problem hiding this comment.
maybe you can use variable argument?
| new($"{OpenResultModifiers}+D0", "HotkeyOpenResultN", 10) | ||
| }; | ||
|
|
||
| if(!string.IsNullOrEmpty(Hotkey)) |
Member
There was a problem hiding this comment.
oh my god this seems terrible lol. I don't know whether there are better way to handle this....
Member
There was a problem hiding this comment.
maybe at least split it to another function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the PR
Now that users have the ability to customize many hotkeys in Flow Launcher, we should prevent them from accidentally using the same hotkey for multiple actions.
Todo
Flow.Launcher.Infrastructure.UserSettings.SettingsThings to consider
Maybe offer the ability to remove the other hotkey directly from the hotkey change dialog?Done.