Add space for pinyin translation #235
Conversation
jjw24
added
the
review in progress
| { | ||
| var result = WordsHelper.GetPinyin(content, ";"); | ||
| result = GetFirstPinyinChar(result) + result.Replace(";", ""); | ||
| var result = WordsHelper.GetPinyin(content, " "); |
There was a problem hiding this comment.
with this change, when i pinyin search '你好' for 'nihao' it doesnt hit as it return splitted up 'ni hao'
There was a problem hiding this comment.
I don't think anybody would use Chinese to search for pinyin like characters.... If both are chinese, it will be fine because the string to compare will also contain space.
There was a problem hiding this comment.
I don't think anybody would use Chinese to search for pinyin like characters.... If both are chinese, it will be fine because the string to compare will also contain space.
There was a problem hiding this comment.
ok so we dont need to worry about chinese to pinyin.
There was a problem hiding this comment.
No, because the reason using pinyin is to make searching faster by reducing the process of typing Chinese, since typing Chinese require extra typing.
| private string GetFirstPinyinChar(string content) | ||
| { | ||
| return string.Concat(content.Split(';').Select(x => x.First())); | ||
| return string.Concat(content.Split(' ').Select(x => x.First())); |
There was a problem hiding this comment.
need to add remove empty entries otherwise it will throw because you are doing First():
return string.Concat(content.Split(' ', StringSplitOptions.RemoveEmptyEntries).Select(x => x.First()));
There was a problem hiding this comment.
Well it isn't an issue before because the translated query won't contain something like ;;, but since we now use space to split. I will take a look on the translated query when the original query contain both Chinese and letter and space.
|
hmm i think this change solves acronym pinyin search but due to the way result could be constructed, it's not hitting query like 'nihao' or 'ni hao' for my test case, the score is too low for my test example below: although i dont know if what i am using is a valid test example. I dont use a Chinese OS system, can you give me an example to test |
I believe the weird situation of your testing is due to that the space will be added to all character used for translation due to the Pinyin library characteristic. The situation also exist in current situation, though not significantly which only affect the acronym part. I will contact the author to ask whether he is able to add the split character only to Chinese character instead of all character. Before his response, I will try to find alternative solution. |
|
@jjw24 I manually set the space instead of using the method provided by the library. It seems works fine, now. |
optimize Chinese character check logic Co-Authored-By: ToolGood <[email protected]>
jjw24
added
enhancement
3 participants
close #229